Repository navigation
fix(english/novelupdates): restore parseNovel when mypostid is missing - #2831
Open
Gourab0002 wants to merge 1 commit into
Open
Gourab0002 wants to merge 1 commit into
Gourab0002 wants to merge 1 commit into
Conversation
Series pages no longer include input#mypostid, so opening a novel threw and showed "Unable to load novel". Fall back to body.postid-N / sid= links for the chapter AJAX id, and skip chapter rows without an href. Co-Authored-By: Grok Bot (AI agent)
 [Low impact] The PR appears safe to merge; no actionable regression was found. SummaryUpdates Novel Updates to
No actionable issues were found. Reviews (1) · Last reviewed commit: "fix(english/novelupdates): restore parse..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2820.
Novel Updates series pages no longer include the hidden
input#mypostidfield thatparseNovelused for the chapter AJAX call. Popular/search still worked, but opening a novel crashed with "Unable to load novel". Library entries were fine because they already had a cached chapter list.This falls back to the WordPress
body.postid-Nclass (and?sid=links) for the series id, keeps usingnd_getchapters, and skips chapter rows that have no href.Plugin version:
0.9.9→0.9.10.Test plan
npx tsc --project tsconfig.production.json --noEmitnpx eslint plugins/english/novelupdates.tsnpm run build:full17042recovered without#mypostidnpm run check:plugin -- plugins/english/novelupdates.ts— INCONCLUSIVE here (HTTP 403 Cloudflare from this host). Please re-run from CI / a non-blocked network.