Repository navigation
Fix: Novels not showing up - #2832
SupremeMango wants to merge 1 commit into
Conversation
[Low impact] The change affects NovelDex, not shared plugin behavior. The PR appears safe to merge, with one non-blocking comment cleanup. Findings
SummaryAdds support for component names stored in separate rows of NovelDex responses.
Reviews (1) · Last reviewed commit: "Fix: Novel not showing up" · Reviewed by Greptile |
| ), | ||
| ); | ||
| return match ? match[1] : null; | ||
| return indirect ? indirect[1] : null; // or indirect[2] |
There was a problem hiding this comment.
// or indirect[2] suggests an incorrect alternative. That group holds the module id, while extractSeriesPage and extractBrowsePage need the row id to find a $L reference. Following this comment could break novel lists or details. Remove the trailing comment; the current return value is correct.
| return indirect ? indirect[1] : null; // or indirect[2] | |
| return indirect ? indirect[1] : null; |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Checklist
type(scope): description(e.g.feat(<generator>): add new source)Fixes #2079
The issue was script not being able to find the client id with the old regex
Fix updated the regex used to find the client id.
Plugin version:
1.0.0→1.0.1