Skip to content

Fix: Novels not showing up - #2832

Open
SupremeMango wants to merge 1 commit into
lnreader:masterfrom
SupremeMango:client-id-regex-fix
Open

SupremeMango wants to merge 1 commit into
lnreader:masterfrom
SupremeMango:client-id-regex-fix

Conversation

@SupremeMango

Copy link
Copy Markdown
Contributor

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)
  • Commit messages follow type(scope): description (e.g. feat(<generator>): add new source)

Fixes #2079

The issue was script not being able to find the client id with the old regex
Fix updated the regex used to find the client id.

Plugin version: 1.0.0 → 1.0.1

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change affects NovelDex, not shared plugin behavior.

The PR appears safe to merge, with one non-blocking comment cleanup.

Findings

  1. P2 Comment suggests the wrong id ▶

Summary

Adds support for component names stored in separate rows of NovelDex responses.

  • NovelDex search and series pages now find novels in both response layouts.

Reviews (1) · Last reviewed commit: "Fix: Novel not showing up" · Reviewed by Greptile

),
);
return match ? match[1] : null;
return indirect ? indirect[1] : null; // or indirect[2]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Comment suggests the wrong id

// or indirect[2] suggests an incorrect alternative. That group holds the module id, while extractSeriesPage and extractBrowsePage need the row id to find a $L reference. Following this comment could break novel lists or details. Remove the trailing comment; the current return value is correct.

Suggested change
return indirect ? indirect[1] : null; // or indirect[2]
return indirect ? indirect[1] : null;

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add noveldex.io as a plugin

2 participants