Conversation
Every devicestatus upload carries loop.testingDetails.remoteCommands with the notification keys the patched build accepts, so LoopFollow can gate the carb delete and edit actions on it. All three patch files are regenerated from clean trees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds remote delete and edit of carb entries in Loop, sent from LoopFollow. Handle is the entry's syncIdentifier. Delete sends carbs-delete. Edit sends carbs-edit with carbs-edit-entry, carbs-edit-absorption-time and carbs-edit-start-time, and carbs-edit-food-type when set. OTP, sent-at and expiration are required. Only entries created by Loop within the last 24 hours can be changed. Loop shows a local notification on success and failure and answers with a return push carrying sync_identifier.
Loop advertises the supported commands in devicestatus as loop.testingDetails.remoteCommands on every loop cycle. LoopFollow only shows the actions when that list is present.
Includes combined variants for use together with remote_window, in both orders. The selector picks the right file automatically.
Generated against LoopWorkspace 3.14.8. Verified to apply together with every other customization that applies to 3.14.8.
LoopFollow side: loopandlearn/LoopFollow#756
Selector entry: loopandlearn/lnl-scripts#107