Repository navigation
Docs/lui 74 strive pr template - #102
Merged
Merged
Conversation
…tegration - Updated framework versions to Next.js 16 and React 19. - Clarified i18n implementation details, specifying the use of `next-intl` for user-facing text. - Enhanced descriptions for mobile-first PWA features and design system requirements.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a pull request template, and fixes stale facts in the PR reviewer prompt that
were making the agent give outdated advice.
Template
.github/PULL_REQUEST_TEMPLATE.md. The checklist deliberately covers only whatautomation cannot verify. CI already runs TypeScript, ESLint, Vitest and the build,
and the review agent already checks terminology, design tokens, user identity and
architecture. Repeating those as checkboxes would train people to tick without
reading and would dilute the items that matter.
What is left is what a machine cannot check: whether it was actually tried on a
mobile viewport, whether both message files were updated, whether the docs still
match, and screenshots for visible changes.
The template also asks about changes under
data/. There is nosupabase/migrations/, andmigrate.pyreplays seeds containing test data, so itcannot be pointed at production. PR #60 needed a manual
psqlstep on eachenvironment, in the right order, before the app rolled out. That is the kind of
thing a template should force someone to write down.
Reviewer prompt
Four stale facts, all of which made the agent reason about a project that no longer
exists:
next-intlshipped months agowith English and French. The rule is now stated as it actually is: every
user-facing string goes through
next-intland must exist in bothmessages/en.jsonandmessages/fr.json.@base-ui/react.The pre-auth landing exception stays, with its cross-reference updated.
Closes LUI-74.