Repository navigation
Feat/lui 143 145 enhance define ritual form - #97
Merged
Merged
Conversation
- Integrated a toast notification system to provide user feedback upon successful ritual creation. - Updated the `DefineRitualButton` component to display a confirmation message with an icon when a ritual is saved. - Modified the `RitualFormSheet` and `RitualForm` components to pass the saved ritual values to the toast notification. - Introduced a new `ToastProvider` component to manage toast notifications across the application.
- Wrapped the main content in the ProtectedBaseLayout with the ToastProvider component to enable toast notifications throughout the protected layout. - This integration supports consistent user feedback across the application, complementing recent enhancements to the ritual creation flow.
- Replaced the custom success toast implementation with the useToast hook from the ToastProvider. - Simplified the feedback handling by removing the local state for success messages. - Enhanced user feedback experience by integrating toast notifications directly upon successful feedback submission.
- Updated the `en.json` and `fr.json` files to include a new message for successful ritual definition. - Added the "saved" key to provide user feedback upon defining a ritual, enhancing the overall user experience.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Strive PR Agent ReviewThe review could not be generated for this run (model unavailable or rate-limited). Push again to retry. |
5 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LUI-143: Confirmation toast when a ritual is created
Why
In the synthetic beta study (LUI-142, finding F1), all 3 participants tapped Create ritual, saw the sheet close, and could not tell whether the ritual had been saved. The save did work. What was missing was an acknowledgment right after the action.
What
Ritual defined · {name}(FR:Rituel défini · {name}). It uses the existingToastwith the check icon.UX_WRITING.md: calm and precise, no gamified wording. The·pattern matches the chat log card (Logged · {name}).How
ToastProvider+useToast()(components/ui/toast-provider.tsx), mounted in the protected layout around<main>.RitualForm→RitualFormSheet:onSuccessnow passes the saved values up, and the sheet exposes an optionalonSaved. The edit flow does not use it and is unchanged.DefineRitualButton: callstoast.show(...)when the save succeeds.rituals.create.savedinen.jsonandfr.json. No new styles; the toast uses existing color tokens.Out of scope
createRitualonly revalidates/protected/rituals, not/protected/flow. This was noted during the investigation but left untouched on purpose, to keep this change low risk.Testing
tsc --noEmit,eslint,vitest run(76 passed)What
Ritual defined · {name}(FR:Rituel défini · {name}). It uses the existingToastwith the check icon.UX_WRITING.md: calm and precise, no gamified wording. The·pattern matches the chat log card (Logged · {name}).How
ToastProvider+useToast()(components/ui/toast-provider.tsx), mounted in the protected layout around<main>.RitualForm→RitualFormSheet:onSuccessnow passes the saved values up, and the sheet exposes an optionalonSaved. The edit flow does not use it and is unchanged.DefineRitualButton: callstoast.show(...)when the save succeeds.rituals.create.savedinen.jsonandfr.json. No new styles; the toast uses existing color tokens.Out of scope
createRitualonly revalidates/protected/rituals, not/protected/flow. This was noted during the investigation but left untouched on purpose, to keep this change low risk.Testing
tsc --noEmit,eslint,vitest run(76 passed)