Repository navigation
chore: bump org.jetbrains.kotlin:kotlin-stdlib-jdk8 in /kits/adobemedia/adobemedia-3 - #879
dependabot[bot] wants to merge 1 commit into
Conversation
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 308f0fe. Bugbot is set up for automated code reviews on this repo. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 53b184d. Configure here.
| @@ -1,5 +1,5 @@ | |||
| buildscript { | |||
| ext.kotlin_version = '2.1.20' | |||
| ext.kotlin_version = '2.4.20' | |||
There was a problem hiding this comment.
Kotlin 2.4.20 incompatible with AGP 8.1.4
High Severity
Bumping kotlin_version to 2.4.20 creates a compatibility conflict with the Android Gradle Plugin at version 8.1.4 (line 14). Kotlin 2.4.20 requires AGP 8.5.2 or higher, so the build will fail or exhibit undefined behavior with AGP 8.1.4.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 53b184d. Configure here.
📦 SDK Size Impact ReportWhat the SDK adds to a minified release APK. mParticle Core SDKMeasured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.
mParticle Core + Rokt kitMeasured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see
Rokt SDK+ umbrella (adds the payment extension)
➡️ SDK size impact change is minimal. Raw measurementscore, Target branch: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2511, "baseline_install_bytes": 7528, "core_dex_bytes": 218884, "core_download_bytes": 122937, "core_install_bytes": 130187}core, This PR: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2507, "baseline_install_bytes": 7524, "core_dex_bytes": 218884, "core_download_bytes": 122931, "core_install_bytes": 130181}rokt, Target branch: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4156052, "kit_download_bytes": 2540333, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9278708, "sdkplus_download_bytes": 7978466, "sdkplus_install_bytes": 8148975}rokt, This PR: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4156052, "kit_download_bytes": 2540336, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9278708, "sdkplus_download_bytes": 7978467, "sdkplus_install_bytes": 8148975} |
308f0fe to
3cbc932
Compare
Kotlin migration progressNo change to the Java left to convert.
Conversion progress: 0.0% (16,608 of 16,550 baseline Java LOC left to convert). 132 Java files and 36 Kotlin files in scope. |
Binary compatibility
Compares the release AAR against the same artifact at the last version published to Maven Central; R8-renamed classes and members are excluded (see the script docstring). Full japicmp HTML/XML reports are attached as the |
Bumps [org.jetbrains.kotlin:kotlin-stdlib-jdk8](https://github.com/JetBrains/kotlin) in `/kits/adobemedia/adobemedia-3` from 2.1.20 to 2.4.20. Updates `org.jetbrains.kotlin:kotlin-stdlib-jdk8` from 2.1.20 to 2.4.20 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.1.20...v2.4.20) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-stdlib-jdk8 dependency-version: 2.4.20 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: shared-gradle-dependencies/org.jetbrains.kotlin:kotlin-stdlib-jdk8 ... Signed-off-by: dependabot[bot] <support@github.com>
3cbc932 to
b2f441d
Compare
|
Not compatible |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
1 participant
Bumps org.jetbrains.kotlin:kotlin-stdlib-jdk8 in
/kits/adobemedia/adobemedia-3from 2.1.20 to 2.4.20.Updates
org.jetbrains.kotlin:kotlin-stdlib-jdk8from 2.1.20 to 2.4.20Release notes
Sourced from org.jetbrains.kotlin:kotlin-stdlib-jdk8's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlin:kotlin-stdlib-jdk8's changelog.
... (truncated)
Commits
890ac1dAdd Changelog for 2.4.20-RC38860aed🍒 [FIR] Fix suspend conversion when expected type is nullable (#7769)ab5bcd9Edit ChangeLog for 2.4.20-RC29464edcAdd ChangeLog for 2.4.20-RC20261e43Cherry-pick "FixasBodyAndResultVarcall in `visitInlinedLambdaInComposable...0763513[box-tests] Workaround for klib compatibility tests (#7626)045aec6[Wasm] Append scripts from webpack.config.d in the end of the file (#7615)cd7173b🍒 [2.4.20] [K/JS] Keep associated obj annotation only if getInstance survives...d36a2ffCastsOptimizationPass: break aliases cycles (#7578)8664983[CLI] Restore custom IC search scope creation