Repository navigation
chore: bump com.vanniktech:gradle-maven-publish-plugin in / - #881
dependabot[bot] wants to merge 1 commit into
Conversation
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 98e7b96. Bugbot is set up for automated code reviews on this repo. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8fc6e7e. Configure here.
|
|
||
| dependencies { | ||
| implementation("com.vanniktech:gradle-maven-publish-plugin:0.31.0") | ||
| implementation("com.vanniktech:gradle-maven-publish-plugin:0.37.0") |
There was a problem hiding this comment.
Plugin requires Gradle 9.0 but project uses 8.5
High Severity
Bumping gradle-maven-publish-plugin to 0.37.0 introduces incompatible minimum version requirements. The plugin now requires Gradle 9.0.0, Kotlin 2.2.0, and AGP 8.13.0, but the project uses Gradle 8.5 (gradle-wrapper.properties), Kotlin 2.1.20 (build.gradle), and AGP 8.3.2. This will break the build entirely since the included build-logic project cannot resolve or apply the plugin with these older toolchain versions.
Reviewed by Cursor Bugbot for commit 8fc6e7e. Configure here.
📦 SDK Size Impact ReportWhat the SDK adds to a minified release APK. mParticle Core SDKMeasured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.
mParticle Core + Rokt kitMeasured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see
Rokt SDK+ umbrella (adds the payment extension)
ℹ️ Size could not be measured on one or both branches. Raw measurementscore, Target branch: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2511, "baseline_install_bytes": 7528, "core_dex_bytes": 218884, "core_download_bytes": 122937, "core_install_bytes": 130187}core, This PR: not measuredrokt, Target branch: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4156052, "kit_download_bytes": 2540333, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9278708, "sdkplus_download_bytes": 7978466, "sdkplus_install_bytes": 8148975}rokt, This PR: not measured |
📦 SDK Size Impact ReportWhat the SDK adds to a minified release APK. Measured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see mParticle Core + Rokt kit
Rokt SDK+ umbrella (adds the payment extension)
ℹ️ Size could not be measured on one or both branches. Raw measurementsTarget branch: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4156052, "kit_download_bytes": 2540334, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9278708, "sdkplus_download_bytes": 7978466, "sdkplus_install_bytes": 8148975}This PR: not measured |
98e7b96 to
bc58a6f
Compare
Kotlin migration progressNo change to the Java left to convert.
Conversion progress: 0.0% (16,608 of 16,550 baseline Java LOC left to convert). 132 Java files and 36 Kotlin files in scope. |
Binary compatibility
|
Bumps [com.vanniktech:gradle-maven-publish-plugin](https://github.com/vanniktech/gradle-maven-publish-plugin) in `/` from 0.31.0 to 0.37.0. Updates `com.vanniktech:gradle-maven-publish-plugin` from 0.31.0 to 0.37.0 - [Release notes](https://github.com/vanniktech/gradle-maven-publish-plugin/releases) - [Changelog](https://github.com/vanniktech/gradle-maven-publish-plugin/blob/main/CHANGELOG.md) - [Commits](vanniktech/gradle-maven-publish-plugin@0.31.0...0.37.0) --- updated-dependencies: - dependency-name: com.vanniktech:gradle-maven-publish-plugin dependency-version: 0.37.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: shared-gradle-dependencies/com.vanniktech:gradle-maven-publish-plugin ... Signed-off-by: dependabot[bot] <support@github.com>
bc58a6f to
9409f8f
Compare
|
Not compatible |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
1 participant
Bumps com.vanniktech:gradle-maven-publish-plugin in
/from 0.31.0 to 0.37.0.Updates
com.vanniktech:gradle-maven-publish-pluginfrom 0.31.0 to 0.37.0Release notes
Sourced from com.vanniktech:gradle-maven-publish-plugin's releases.
... (truncated)
Changelog
Sourced from com.vanniktech:gradle-maven-publish-plugin's changelog.
... (truncated)
Commits
7017e3denable feature preview (#1381)05f6b6euse 0.37.0-rc1 (#1380)0167c9cChangelog for 0.37.0 (#1379)b652eb3Update dependency java to v26 (#1353)a9f70b3Update dependency com.freeletics.gradle:scripts-formatting-jvm to v0.37.0 (#1...541cf8fLog deployment id and publishing type after Central Portal upload (#1354)d4873e5Update slf4j monorepo to v2 (#1365)42baf9dUpdate android.gradle (#1335)2de1978Update Gradle (#1362)6f03e46Update kotlin monorepo to v2.4.0 (#1352)