Repository navigation
fix(builders): harden stream pagination, RFC 8058 builders, and PEP 440 semver - #176
Draft
skupriienko wants to merge 1 commit into
Draft
skupriienko wants to merge 1 commit into
skupriienko wants to merge 1 commit into
Conversation
This was referenced Nov 15, 2026
skupriienko
marked this pull request as draft
November 15, 2026 16:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (v1.9.2 Hardening Rollout)
master<-wave-1-tooling-hygieneCRIT-03,CRIT-04,CRIT-05,HIGH-06wave-1-tooling-hygiene<-wave-2-transport-redactionCRIT-01,CRIT-02,HIGH-01(lock),HIGH-02,HIGH-03,HIGH-04(path),OPT-09wave-2-transport-redaction<-wave-3-boot-slots-poolingOPT-01..OPT-07,OPT-10,OPT-11,HIGH-01(warn_unclosed)wave-3-boot-slots-pooling<-wave-4-builders-semverHIGH-04(bool/stream),HIGH-05,HIGH-07,OPT-08wave-4-builders-semver<-wave-5-typing-stateful-testsMOD-02,MOD-04Merge in order: #173 -> #174 -> #175 -> #176 -> #177.
Note
Stacked PR workflow note:
ClusterFuzzLite PR fuzzingruns immediately on all PRs. Workflows scoped tobranches: [master](CI,PR Validation,Continuous Security Verification,CodeQL) trigger automatically as parent PRs merge intomasterand GitHub retargets this PR's base branch tomaster.Summary
Wave 4 of 5 for
v1.9.2(stacked on #175 /wave-3-boot-slots-pooling). HardensEndpoint.stream()pagination boundaries (boolrejection,Offsetnormalization,max_itemscap, malformed JSONMailjetApiError), adds RFC 8058 One-Click Unsubscribe and inlineContentID/cid:validation plus single-encode102 KBGmail clipping and50-message /15 MBbatch guards inbuilders.py, fixes PEP 440 prerelease semver parsing (1.9.1rc2->(1, 9, 1)), and adds optionalorjsoncompact JSON parity plus an ASCII domain normalization fast path.Actions
mailjet_rest/endpoint.py,HIGH-04):boolarguments forchunk_sizeandmax_items, normalized case-insensitiveOffsetfilter keys, enforcedmax_itemsearly termination, and wrapped non-JSON or non-dict.stream()payloads inMailjetApiError.cid:& Gmail Clipping Builders (mailjet_rest/builders.py,mailjet_rest/types.py,HIGH-05):MessageBuilder.set_one_click_unsubscribe()enforcinghttps://URLs withList-UnsubscribeandList-Unsubscribe-Post: List-Unsubscribe=One-Click.ContentIDsupport inadd_inlined_attachment()with missingcid:reference warnings underENABLE_SPAM_GUARD, added single-encode102,400-byte Gmail clipping boundary warnings onHTMLPart, and enforced<= 50messages and<= 15 MBtotal JSON payload caps inSendPayloadBuilder.build().mailjet_rest/utils/version.py,HIGH-07):parse_semver_triplet()and updatedclean_version()so prerelease tags (1.9.1rc2,1.9.2a1,1.9.2.dev3) parse cleanly to(1, 9, 1)/(1, 9, 2)without merging trailing digits.orjson& ASCII Domain Fast Path (mailjet_rest/utils/guardrails.py,OPT-08):orjsonserialization parity with stdlibjson(separators=(",", ":")) and an ASCII domain fast path with RFC 1035 domain and label length bounds innormalize_domain().tests/unit/test_wave4_builders_semver.py,tests/property/*,tests/fuzz/fuzz_pagination_stream.py):cid:warnings,102 KBboundary warnings,1rc2semver assertions, andorjsonparity.Verification & Testing
v1.9.2stack:ruff check .,ruff format --check .,mypy --strict mailjet_rest,pyright mailjet_rest,slotscheck -m mailjet_rest,bandit -c pyproject.toml -r mailjet_rest, andpytest -n auto -W error tests/unit tests/property tests/regression.pytest -m network,samples/smoke_readme_runner.py) were skipped locally due to absentMJ_APIKEY_PUBLIC/MJ_APIKEY_PRIVATEcredentials.