Repository navigation
Correct FiQA's 0.2291: it is the gate, not the analysis - #84
Merged
Merged
Conversation
Ungated, the same english configuration reads 0.2430 (k1=0.9/b=0.4, linear, depth 1,000), above the reference analysis's 0.2378 and the published 0.2361. The 0.2291 the page attributed to a ~0.007 analysis gap is the rare-term gate's recall bound; the budget moves it (1,000 -> 0.2291, 2,000 -> 0.2363, 5,000 -> 0.2417). The default stays 1,000, which is free on NFCorpus and SciFact; the trade is stated on the evaluation and backend pages, and the published 0.2361 remains the in-memory uax29 row's number.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 89.26% 89.27%
=======================================
Files 271 271
Lines 21461 21461
Branches 4635 4635
=======================================
+ Hits 19158 19160 +2
+ Misses 1373 1372 -1
+ Partials 930 929 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this corrects
The FiQA page said the stock-PostgreSQL BM25 row's 0.2291 was "the same ~0.007 analysis gap the other corpora show, not a gate cost". That is wrong. Measured at k1=0.9/b=0.4, linear gains, depth 1,000, default arithmetic:
englishTwo facts follow:
--backend-gate-budgetrecovers it (2,000 → 0.2363, 5,000 → 0.2417). The default stays 1,000, and the trade is now stated.The published 0.2361 remains reproduced by the in-memory
uax29row under the reference's conventions, with an index byte-identical to Lucene 10.5.2's. That claim is unchanged.Files
docs/evaluation.md,docs/backends.md(the gate section gains the FiQA side of the trade),docs/index.md,README.md, the changelog. No code change.This corrects a claim merged in #80/#82, not a regression.