Repository navigation
Merged
Conversation
This was referenced Oct 23, 2026
mathiasrw
added this pull request to stack #841
October 23, 2026 13:56
mathiasrw
removed this pull request from stack #841
October 23, 2026 15:57
mathiasrw
added this pull request to stack #849
October 23, 2026 16:12
mathiasrw
removed this pull request from stack #849
October 23, 2026 16:12
mathiasrw
added this pull request to stack #850
October 23, 2026 16:17
mathiasrw
removed this pull request from stack #850
October 23, 2026 16:47
mathiasrw
added this pull request to stack #853
October 23, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #817
Stacked on #833.
Change
The path of
--replacement-fileis the name of a file, so it is now used as it is:my\dir/new.txtwas looked for asmydir/new.txt, andpartials\new.htmlgot a line break.€and§aliases, as they are never used in globs and file names. Before,price€.txtwas looked for asprice$.txt.With
--jsthe code gives the path, and the code is typed, so the aliases and escapes are still used in the code, as before.Tests
test/fix/817.test.jsis new, and its tests with a backslash and with€fail without the fix.yarn test-cipasses.From the review of 23 October.