Repository navigation
Conversation
mathiasrw
marked this pull request as draft
October 23, 2026 13:05
mathiasrw
marked this pull request as ready for review
October 23, 2026 13:24
mathiasrw
added this pull request to stack #841
October 23, 2026 13:56
mathiasrw
marked this pull request as draft
October 23, 2026 15:30
mathiasrw
marked this pull request as ready for review
October 23, 2026 15:37
mathiasrw
removed this pull request from stack #841
October 23, 2026 15:57
mathiasrw
added this pull request to stack #849
October 23, 2026 16:12
mathiasrw
removed this pull request from stack #849
October 23, 2026 16:12
mathiasrw
added this pull request to stack #850
October 23, 2026 16:17
mathiasrw
removed this pull request from stack #850
October 23, 2026 16:47
mathiasrw
added this pull request to stack #853
October 23, 2026 16:51
mathiasrw
force-pushed
the
fix/820
branch
4 times, most recently
from
October 23, 2026 17:02
f41864a to
cbc9e28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #820
Stacked on #836.
Change
The default order,
natural, is now the same everywhere:naturalsees as the same are ordered by ascii, as the help says. Before, they kept the order of the glob, which differs between Node and Bun.en. Before, Node followed the locale of the user and Bun did not.file1.md file01.md file001.md z.md aa.md cafe.md café.md, with--sort natural:LC_ALL=da_DK.UTF-8, beforeda_DK, nowIt matters most with
--renameand$n, as the numbers follow the order.Tests
test/fix/820.test.jsis new and checks the ties. The locale can not be changed inside the test, so it was checked by hand with Node, as in the table.yarn test-cipasses.From the review of 23 October.
After the review of 24 October
--sort natural, so the files are handled one at a time and printed in the order of the sort. Without it the order the files finish in could make the test flaky.Follow-up
test/fix/820.test.jscovers numbers, case, accents,aaand--sort-reverse, next to the names it sees as the same.test/cli/run.shsortsb.fileandaab.filewithLC_ALL=da_DK.UTF-8on Node and Bun. In Danishaasorts afterz, so Node gaveb.filefirst before the fix.