Repository navigation
Conversation
…nd never crash on it
…thout a conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #839
Stacked on #838.
Change
When the reader of a pipe stops early, like
head, nobody reads the rest, and that is fine. Before, the run crashed with EPIPE and a stack trace, and exit code 1:Now the run ends as usual, with no error, on Bun and on Node:
-d | head -1is fine too.Tests
test/fix/839.test.jsis new. It pipes 200,000 lines intohead -1, also with the status report, and fails without the fix.yarn test-cipasses.Also closes #852
Follow-up
The detail of an error, like the file, is now on its own line under the message, for every error: