Repository navigation
revert(editor): restore 1.3.3 page engine (1.3.5 build 19) - #37
Merged
Merged
Conversation
… (1.3.5 build 19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the OpenNotes 1.3.3 editor and Mobile Ink 0.3.6 page engine. On a physical iPad, the continuous cross-page renderer in 1.3.4/1.3.5 caused 0.5–2 s main-thread freezes during writing, pan and zoom (HangTracer reports: synchronous tile rendering in
MTKView.draw).The tree is identical to 5eb7079 (1.3.3) except the version bump to 1.3.5 (19). Strokes and assets crossing page boundaries are disabled until the renderer is rebuilt and device-verified.
Compatibility was verified on the simulator: notes saved by the 1.3.4/1.3.5 continuous builds (including a 100-page dense note and a note with a crossing stroke) open with their ink; crossing strokes display clipped at the page edge. Re-saving such a note in this build keeps every stroke (verified: 201 strokes before, 202 after drawing one more; the crossing stroke is retained whole).