[thecristen]

Scope

Asana Ticket: Two services tagged as "(Now)"

Implementation

Note

🤖 In my initial research, I had Copilot rewrite the services picker dropdown with different logic, to analyze the active dates for every service, then split/recombine based on common groups of dates. The end result was pretty cool, and solved the double (Now) issue, but the dropdown was arguably even more confusing.
None of that's in this PR, but it did help us commit to trying out this datepicker!

• Reuses the existing Datepicker LiveComponent
  • No time input, only date
  • Custom formatting
  • Is also updated when a date link is clicked on (the link to today, or any links to holiday dates)
  • 
  • Only enables dates where the route is in service (in general, not specific to the viewed stop/direction)
  • 
• Instead of rerunning the Services.Service.all_valid_dates_for_service/1 logic constantly, now we just do it once when parsing, and save it as part of the %Service{} struct.
• DotcomWeb.ScheduleController.LineController only used services for the now-deleted Schedule Finder modal, so it should've been removed in chore: Remove old SF1.0 code #3654 ... well, now it's deleted here
• Which let us remove Dotcom.ServicePatterns.services_for_route/1 and a bunch of helper functions around that
• And removing the service dropdown itself let us remove a bunch more!

How to test (with screenshots)

Deploying on dev-blue so we can play with it on a few different routes. Some fun examples:

• /departures/?route_id=CR-Foxboro&stop_id=place-bbsta&direction_id=0 A few outbound stops to Foxboro don't have service today, but will soon. Just like before, landing on that page will immediately show you the next scheduled trips. Fun fact there are only two games scheduled within the relevant service date range (not every weekend as the dropdown might suggest):

Before	After

Not all routes have services associated with holiday services. Some of the subways do, e.g. the Red Line:

[lvachon1]

I like it! (non-blocking comment): The Hingham/Hull Ferry runs weekdays year-round, but will not run on Thanksgiving Thursday. Other adjusted holiday scheduled get called out, should an adjustment to zero also be included?