Show saves, failures and progress on the Reader mark - #50
Merged
Merged
Conversation
Load @mdbase-dev/ui's motion.css after brand.css so the app switcher's mark can animate, and fill the mark with the progress Reader already measures: a bulk status or field update (sources done of total), a library migration (records completed of total) and a file upload (bytes sent of total). Each ends with saved, or with error when any source or the import failed; a stopped import or upload ends quietly. withMarkProgress always ends the tracked operation, whatever the work does, so the mark never stays filling. Needs @mdbase-dev/ui 0.1.0-beta.122, which is not yet published.
Play saved or error on the app mark for user-initiated writes that do not go through SaveNotice: creating a highlight or annotation, saving an annotation edit, saving a citation or source details, editing a library cell, exporting a bibliography and adding a source from a link. The mark scans while a link is being captured, which has no measurable progress, and streams while the header reports syncing.
callumalpass
force-pushed
the
feat/mark-motion
branch
from
October 2, 2026 21:51
d673d53 to
ac76a6e
Compare
callumalpass
marked this pull request as ready for review
October 2, 2026 21:51
callumalpass
force-pushed
the
feat/mark-motion
branch
from
October 2, 2026 21:51
d673d53 to
ac76a6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the mark animations from mdbase-dev/mdbase-connect#555. This is a draft until
@mdbase-dev/uiwithmark-activityis published to npm. It then needs the dependency bump inapps/reader,apps/extension,packages/uiandpackages/markdown-editor.motion.cssis imported withbrand.css.errorscanwhile capturing a web page, andstreamwhile the header reports syncing. Nothing sets that state yet, sostreamwon't play until something does.apps/reader/src/mark-activity.tsaddswithMarkProgress, which always ends the tracked operation (finish, fail, or quietly on abort).Verified against a packed build: typecheck, lint, and all tests (reader: 398, including 9 new). In preview mode, a bulk status update showed progress, then saved.