Skip to content

Use shared private feedback with published UI beta.124 - #52

Merged
callumalpass merged 2 commits into
mainfrom
feat/shared-feedback
Oct 3, 2026
Merged

callumalpass merged 2 commits into
mainfrom
feat/shared-feedback

Conversation

@callumalpass

@callumalpass callumalpass commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Shared private feedback

Uses the actual published @mdbase-dev/ui@0.1.0-beta.124, with normal registry dependencies/lockfile and no local worktree links. Integrated current Reader main and resolved the header conflict while preserving the new mark activity and resource/schema upgrades.

The shared form owns description-first reporting, explicit optional screenshots/markup, three topics and consented bounded diagnostics. Reader supplies only fixed product/view/build metadata plus opt-in collection context. No telemetry, raw exception text or new delivery adapter.

Qualified locally from a fresh frozen install

  • Full lint/format/architecture, workspace typechecks/tests and production builds. Reader app: 401 tests; extension: 169 tests.
  • PDF gestures/mobile persistence regressions.
  • Desktop/mobile private-feedback browser acceptance using the real published package; every feedback POST intercepted and no email sent.
  • CI now runs the intercepted feedback browser suite, and deployment workflows map environment-scoped public feedback variables.

Rollout boundary

The compatible Worker and UI publication are complete. Exact Reader/Writer host configuration is proposed separately in mdbase-cloud-ops #741 (draft), pending explicit host confirmation, Turnstile Edit credential and live staging/inbox acceptance. Leave deployment feedback variables unset until accepted; entries remain hidden. This PR does not alter widgets/secrets/Worker origins, enable feedback in a live build, or deploy production. Normal CI/merge and separate protected app rollout gates remain mandatory.

@callumalpass

Copy link
Copy Markdown
Contributor Author

Shared implementation merged in mdbase-dev/mdbase-connect#558 at ef35e45047a1aea15abeb58ddd8179dc12b8e16c after successful full merge-queue qualification (attempt 2). This consumer remains a draft: update UI pins/lockfile only once the normal coordinated release publishes these exports, then repeat clean-install CI and acceptance before merging. No package or service was published/deployed by this task.

@callumalpass callumalpass changed the title Integrate shared private feedback (UI release required) Use shared private feedback with published UI beta.124 Oct 3, 2026
@callumalpass
callumalpass marked this pull request as ready for review October 3, 2026 04:03
@callumalpass
callumalpass merged commit c303f3e into main Oct 3, 2026
3 of 4 checks passed
@callumalpass

Copy link
Copy Markdown
Contributor Author

Qualified against the real published UI beta.124 from a fresh frozen install. Local full checks/build, PDF regression and intercepted desktop/mobile feedback acceptance passed. Exact-head GitHub CI passed on attempt 2 after one existing PDF long-press selection failure on attempt 1; no test/timeouts/checks were bypassed. Source integration is merged; live feedback remains disabled until the reviewed host/widget/acceptance gate in cloud-ops #741 is completed.

@callumalpass
callumalpass deleted the feat/shared-feedback branch October 3, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant