Stop tracking generated sources; sync them in the Connect release update - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schemas, contracts, conformance data and theme files written by
pnpm sync:sourceswere committed, butci.ymlanddeploy.ymlregenerate them from the refs insite-sources.jsonbefore every build. The committed copies therefore never reached production and drifted silently; the Connect schemas went unsynced from #20 until #79.site-sources.jsonis now the only source of truth..gitignorenow covers every sync output, and 224 generated files are untracked.connect/schemas/contract-extension.v1.schema.jsonstays tracked. Connect removed it in Implement first-class data contract access mdbase-connect#99, so the site only serves it because it's committed, and this keeps its public URL.pnpm test. Previously it tested against whatever was committed. Generated files are ignored, so the release-only change guard is unchanged.site-sources.jsoncontrols what's published.Verified in a fresh clone with sources checked out at the pinned refs.
sync:sourcesleavesgit statusclean, andpnpm testpasses in full (spec, home, docs, release checks, astro check, build, spec import, links). The builtmdbase-app.schema.json,contracts/catalog.jsonandmdbase-theme.cssare byte-identical to production. The kept schema, themdbase-app.v1.jsonalias and the rc.18 pack are present.