Repository navigation
test: run the tfstate tests on a building block of our own - #35
Merged
Merged
Conversation
|
Coverage of the acceptance run against the meshStack backend, on
Uncovered functions
|
grubmeshi
force-pushed
the
test/own-noop-building-block
branch
from
October 14, 2026 07:27
40e40cf to
ed77b44
Compare
exec now writes the backend override where tofu runs the module: the directory that tofu's or terraform's -chdir=DIR names, or else the working directory. So several execs can run at once on separate copies of a module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bootstrapped building block ran the noop module of meshstack-hub, so a change there broke TestAccTfstate, as the last commit fixed. Its definition now runs testdata/buildingblock, a single terraform_data, at the commit under test, which the exec tests apply as well. The test checks that GitHub has that commit, because the tf-block-runner clones it from there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
meshfed-release tests a pull request at refs/pull/N/merge, which the tf-block-runner cannot check out: it clones only branches and tags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The acceptance tests now write and remove the override, so its unit test keeps only the refusal to replace a file that is there already. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grubmeshi
force-pushed
the
test/own-noop-building-block
branch
from
October 14, 2026 07:37
ed77b44 to
f158634
Compare
grubmeshi
changed the base branch from
main
to
dependabot/go_modules/go-modules-3c91e990d9
October 14, 2026 07:37
meshfed-release keys the cached result on the Go sources only, so a change to a .tf file under testdata alone reused a stale result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base automatically changed from
dependabot/go_modules/go-modules-3c91e990d9
to
main
October 14, 2026 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestAccTfstatebootstrapped a block of meshstack-hub's noop e2e module, so a change in hub broke it (see 15fc759). The bootstrap now creates its own definition, which runstestdata/buildingblock, a singleterraform_data, at the commit under test.exec --override-backendwrites the override into the directory oftofu -chdir=DIR(orterraform), parsed as OpenTofu'sextractChdirOptiondoes, and into the working directory otherwise.ref_nameis the HEAD of the checkout. When the lane tests the PR's merge commit, which the runner cannot clone, it is the PR head. The test fails early with "push HEAD … first" when GitHub does not have the commit.--override-backend; the concurrent execs each run their own copy. The override's unit test keeps only the refusal to replace an existing file.🤖 Generated with Claude Code