Skip to content

fix(meshstack/noop): keep test_context.meshstack optional in the e2e root - #388

Closed
tfelix wants to merge 1 commit into
mainfrom
feature/noop-e2e-optional-tag-schema
Closed

tfelix wants to merge 1 commit into
mainfrom
feature/noop-e2e-optional-tag-schema

Conversation

@tfelix

@tfelix tfelix commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Written by AI agent

meshstack-cli's acceptance test TestAccTfstate orders noop through this e2e root from ref=main. Its test_context has no meshstack group, so since #374 tofu init fails with attribute "meshstack" is required. This breaks build-acceptance-e2e on every meshfed-release PR.

The meshstack group is now optional. Without it, the e2e Payment Method gets no tags, which fits a fresh instance with no mandatory tags. The hub smoke test still passes the real tag schema.

Validation: I ran the meshstack-cli acceptance suite locally (./gradlew :meshstack-cli:acceptanceTest from meshfed-release) with the fixture pointed at this branch. It passed, including TestAccTfstate.

🤖 Generated with Claude Code

…root

meshstack-cli's acceptance test orders noop through this e2e root from
ref=main and passes a test_context without the meshstack group. Since the
Payment Method input, tofu init fails there. Without the group, the
Payment Method now gets no tags, which fits an instance with no mandatory
tags.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Scorecard Check

Scorecard run on commit a9a9b76a9d04cf0d17cd15872bada65dd9e1e097 relative to origin/main

📊 meshstack-hub Module Scorecard

Generated: 2026-10-13 | Modules scanned: 1 | Categories: 7

📋 Per-Module Category Summary

Score per category per building block. n/a = category does not apply to this module.

Module Overall Core Structure Integration AWS Backplane Azure Backplane GCP Backplane STACKIT Backplane Testing
meshstack/noop 🟢 100% 🟢 100% 🟢 100% n/a n/a n/a n/a 🟢 100%

✅ All checks passing! This module meets all scorecard criteria.

Core Structure — ✅ all passing

Basic module file structure and documentation — applies to 1 modules

Module Score 📦 🔗 📋 📝 🖼️ 📌 🚦 🎯 🩹 🧼 ❄️ 🔒
meshstack/noop 🟢 100% ✅ ✅ ➖ ✅ ✅ ✅ ➖ ✅ ✅ ✅ ✅ ✅

Core Structure — Summary

Emoji Criterion Coverage Status
📦 buildingblock/ directory exists 1/1 🟢 100%
🔗 meshstack_integration.tf present 1/1 🟢 100%
📋 buildingblock/APP_TEAM_README.md present (no-integration fallback) n/a —
📝 buildingblock/README.md with YAML front-matter 1/1 🟢 100%
🖼️ buildingblock/logo.png included 1/1 🟢 100%
📌 buildingblock/versions.tf present 1/1 🟢 100%
🚦 Child meshstack_building_block asserts a SUCCEEDED run n/a —
🎯 meshStack *_ref attributes use the resource's ref output 1/1 🟢 100%
🩹 Every try() carries a comment saying why 1/1 🟢 100%
🧼 Pre-run scripts install no tools on the runner 1/1 🟢 100%
❄️ A module flake sits in nix/, is pinned, and Terraform calls it 1/1 🟢 100%
🔒 Provider versions float within one major (>= X.Y.Z, < N.0.0) 1/1 🟢 100%
Integration — ✅ all passing

meshstack_integration.tf conventions — applies to 1 modules

Module Score 🏷️ 🏢 📤 🔌 📎 🔀 🌱 📋 🏷️ 🧱 🏪 📖 📝 📊 🚫 🔄 🪪
meshstack/noop 🟢 100% ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ➖ ➖

Integration — Summary

Emoji Criterion Coverage Status
🏷️ variable "hub" in integration 1/1 🟢 100%
🏢 variable "meshstack" in integration 1/1 🟢 100%
📤 building_block_definition output exposed 1/1 🟢 100%
🔌 meshcloud/meshstack in required_providers 1/1 🟢 100%
📎 backplane source uses var.hub.git_ref 1/1 🟢 100%
🔀 ref_name uses var.hub.git_ref 1/1 🟢 100%
🌱 BBD terraform_version >= 1.12.0 1/1 🟢 100%
📋 version_spec.draft uses var.hub.bbd_draft 1/1 🟢 100%
🏷️ BBD metadata.tags forwards var.meshstack.tags 1/1 🟢 100%
🧱 BBD input argument vars with optional() have explicit defaults 1/1 🟢 100%
🏪 BBD catalog properties are overridable 1/1 🟢 100%
📖 BBD readme field present 1/1 🟢 100%
📝 BBD readme starts with plain-text description (no heading) 1/1 🟢 100%
📊 BBD readme has shared responsibility table (✅/❌) 1/1 🟢 100%
🚫 No documentation_md output in backplane 1/1 🟢 100%
🔄 meshstack_platform has lifecycle ignore_changes = [availability] n/a —
🪪 Trusts the runner's identity, not the replicator's n/a —
AWS Backplane — not applicable

AWS automation principal conventions (WIF or cross-account StackSet) — applies to 0 modules

No applicable modules.

Azure Backplane — not applicable

Azure UAMI-based automation principal conventions — applies to 0 modules

No applicable modules.

GCP Backplane — not applicable

GCP workload-identity-federation automation principal conventions — applies to 0 modules

No applicable modules.

STACKIT Backplane — not applicable

STACKIT WIF-based automation principal conventions — applies to 0 modules

No applicable modules.

Testing — ✅ all passing

End-to-end test coverage — applies to 1 modules

Module Score ⚙️ 🧪 🚫 ✅
meshstack/noop 🟢 100% ✅ ✅ ✅ ✅

Testing — Summary

Emoji Criterion Coverage Status
⚙️ backplane/ directory (optional tier) 1/1 🟢 100%
🧪 e2e/ test directory exists 1/1 🟢 100%
🚫 no .tftest.hcl outside e2e/ 1/1 🟢 100%
✅ e2e/ contains .tftest.hcl files 1/1 🟢 100%

@aws-amplify-eu-central-1

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-388.d1o16zfeoh2slu.amplifyapp.com

@tfelix

tfelix commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Written by AI agent

Closed in favour of meshcloud/meshstack-cli#34. That PR keeps test_context.meshstack required, as the e2e-test skill asks, and makes the cli fixture pass it.

@tfelix tfelix closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant