Skip to content

fix display the current pyrefly version in the sandbox #3802 - #4435

Closed
asukaminato0721 wants to merge 2 commits into
meta:mainfrom
asukaminato0721:3802
Closed

asukaminato0721 wants to merge 2 commits into
meta:mainfrom
asukaminato0721:3802

Conversation

@asukaminato0721

Copy link
Copy Markdown
Collaborator

Summary

Fixes #3802

export version from cargo env into wasm and insert into tsx

Test Plan

add test

@meta-cla meta-cla Bot added the cla signed label Aug 4, 2026
@meta-codesync

meta-codesync Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D114725315. (Because this pull request was imported automatically, there will not be any future comments.)

@github-actions github-actions Bot added the size/s label Aug 4, 2026
@github-actions

This comment has been minimized.

@yangdanny97

Copy link
Copy Markdown
Collaborator

Jia had a concern that this could still cause confusion, since the sandbox saying v.1.2.0 doesn't mean it's 1.2.0, rather it is 1.2.0 + some commits (potentially several hundred)

so something might work in the sandbox but not work if a user downloads 1.2.0

it might make sense to show a commit timestamp or commit hash instead, set when the website update script runs. for local builds we can show a placeholder or nothing

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@rchen152 rchen152 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This LGTM. I had to patch the imported copy of this change to fix our internal build (not the fault of this PR - internal build files aren't exported to GitHub), so I'll have to get a second review before merging.

@stroxler stroxler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot closed this in 7de9983 Nov 2, 2026
@meta-codesync meta-codesync Bot added the Merged label Nov 2, 2026
@meta-codesync

meta-codesync Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@rchen152 merged this pull request in 7de9983.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

display the current pyrefly version in the sandbox

4 participants