Repository navigation
fix display the current pyrefly version in the sandbox #3802 - #4435
asukaminato0721 wants to merge 2 commits into
Conversation
|
This pull request has been imported. If you are a Meta employee, you can view this in D114725315. (Because this pull request was imported automatically, there will not be any future comments.) |
This comment has been minimized.
This comment has been minimized.
|
Jia had a concern that this could still cause confusion, since the sandbox saying v.1.2.0 doesn't mean it's 1.2.0, rather it is 1.2.0 + some commits (potentially several hundred) so something might work in the sandbox but not work if a user downloads 1.2.0 it might make sense to show a commit timestamp or commit hash instead, set when the website update script runs. for local builds we can show a placeholder or nothing |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
89be443 to
f180d4e
Compare
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
rchen152
left a comment
There was a problem hiding this comment.
Thanks! This LGTM. I had to patch the imported copy of this change to fix our internal build (not the fault of this PR - internal build files aren't exported to GitHub), so I'll have to get a second review before merging.
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary
Fixes #3802
export version from cargo env into wasm and insert into tsx
Test Plan
add test