Repository navigation
ci: gate showcase output in all five ports and regen stale output - #449
Merged
Merged
Conversation
… in the full CI run
… the new all-ports showcase gate. Left AGENTS.md unchanged: it omits the new gate but is not wrong, and it is a human-owned memory file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
examples/showcaseoutput in four ports after the value-object null-omission and nested-decimal changes:SubscriberBlurbPayload.g.cs(C#,[JsonIgnore(WhenWritingNull)]onName),SubscriberBlurbPayload.java(@JsonInclude(NON_NULL)),SubscriberBlurbPayload.kt(same annotation), andsubscriber_router.py(_NESTED_DECIMALSplus the extra argument tocoerce_decimal_fields)..hashes.jsonis updated to match.gate_showcase_all_portstoscripts/ci-local.sh, which runsregen-showcase --check --all-ports. It runs only in the flagless full run, where mvn, dotnet and uv are all present, and it fails under strict toolchains when any of them is missing.--quickand--onlylanes are unchanged.CONTRIBUTING.mdto list the new showcase gate.Validation
Risk Assessment
✅ Low: The change regenerates four stale showcase outputs and their .hashes.json entries, all matching current emitter source, and adds a flagless-run-only gate in scripts/ci-local.sh that follows the existing step, skip and strict-toolchain patterns.
Testing
Drove the real showcase regen gate across all five ports; it passes on this commit, and it catches a hand-edited generated file. The full release preflight could not run because this worktree is on detached HEAD and the script requires
main; the showcase step it runs is the same command I ran, so that step is covered. Related showcase tests pass. I did not run the complete repo regression suite (docker integration and the full mvn/dotnet lanes are heavy); the baseline ci-local ts-fast/ts-unit lane was already green. Worktree left clean.Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
scripts/ci-local.sh --only ts-fast --only ts-unit --strict-toolchainsbun run --filter '*' build(prerequisite per regen-showcase header)bun scripts/regen-showcase.ts --check --all-ports-> all five ports ok, exit 0Adversarial: appended a line to examples/showcase/generated/csharp/SubscriberBlurbPayload.g.cs, re-ran--check --all-ports-> exit 1, names the file as differing from pristine regen; restored file, tree cleanMO_CI_LIST_ONLY=1 scripts/ci-local.sh-> lists 'showcase current in all ports' in flagless runbun run scripts/release.mjs 1.1.0 --preflight-only-> refused: must be on main (detached HEAD); not bypassedbun test scripts/site-> 168 pass, 0 failbun test packages/cli/test/integration/showcase-drift.test.ts-> 3 pass, 0 fail✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.