Repository navigation
test(java): expect execution-qualified generate command in stale-code advice - #453
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
ConfiguredGeneratorsTest(server/java/maven-plugin) to expect'mvn metaobjects:generate@codegen' deletes it, matching the execution-qualified generate command thatMetaDataVerifyMojonow emits when the generate configuration lives inside an<execution>.generatorRemovedFromAProfile_itsFilesAreCleaned_andVerifyReportsThemFirst, which failed deterministically on main (18 run, 1 fail).Validation
Risk Assessment
✅ Low: One-line test expectation update matching genGoal() output (plugin-level config null, single generate execution "codegen" yields "metaobjects:generate@codegen"); asserts real mojo output, no production change.
Testing
Unit and module tests pass: ConfiguredGeneratorsTest 18/18 and maven-plugin 257/257. Neither scenario was driven against the live product, so both are untested and the verdict is inconclusive. The verify mojo's message is a runtime product surface, so the no-surface verdict does not apply. Live check still needed: run
mvn metaobjects:verifyagainst a project with an execution-scoped generator removed from its profile and confirm the printed command ismvn metaobjects:generate@codegen.Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
scripts/ci-local.sh --only ts-fast --only ts-unit --strict-toolchainsRead ConfiguredGeneratorsTest.java:268-291 and MetaDataVerifyMojo.genGoal() (lines 96-105) and confirmed the message contractgit show fb3a8bec: one-line assertion change from baremetaobjects:generatetometaobjects:generate@codegenmvn -o -pl maven-plugin test -Dtest=ConfiguredGeneratorsTest (run from server/java): 18 run, 0 failures, BUILD SUCCESSmvn -o -pl maven-plugin test (full module, run from server/java): 257 run, 0 failures, BUILD SUCCESSgit status --short after testing: clean worktree⏭️ **Document** - skipped
Step was skipped.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.