Skip to content

fix(import-url): validate artifact URL scheme #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dipak0000812 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(import-url): validate artifact URL scheme #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f31e44
fix(import-url): validate artifact URL scheme
dipak0000812 Sep 30, 2026
2806c15
fix(import-url): validate artifact URL scheme
dipak0000812 Oct 11, 2026
a64d332
fix(import-url): remove redundant scheme check
dipak0000812 Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 28 additions & 17 deletions cmd/importURL.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,8 @@ func NewImportURLCommand(globalClientOpts *connectors.ClientOptions) *cobra.Comm
Use: "import-url",
Short: "import API artifacts from URL on Microcks server",
Long: `import API artifacts from URL on Microcks server`,
Args: validateImportURLArgs,
RunE: func(cmd *cobra.Command, args []string) error {
// Parse subcommand args first.
if len(args) == 0 {
return errors.Wrapf(errors.KindUsage, "import-url requires a <specificationFileURL[:primary[:secret]]> argument")
}

specificationFiles := args[0]

mc, _, err := newCommandClient(globalClientOpts)
Expand Down Expand Up @@ -64,24 +60,39 @@ func NewImportURLCommand(globalClientOpts *connectors.ClientOptions) *cobra.Comm
return importURLCmd
}

func validateImportURLArgs(cmd *cobra.Command, args []string) error {
if len(args) == 0 {
return errors.Wrapf(errors.KindUsage, "import-url requires a <specificationFileURL[:primary[:secret]]> argument")
}
Comment on lines +63 to +66

@Vaishnav88sk Vaishnav88sk Oct 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing before merge: validateImportURLArgs only rejects len(args) == 0. Running import-url url1 url2 silently drops url2. Please return a usage error for len(args) > 1 that points to the comma-separated form.


@lekaf974 lekaf974 Oct 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this way it gives to many responsibilities to this function.
Cobra offer pre-hook Args which is the right place for this kind of validation
this is also valid for the if len(arg) == 0 check

@Harsh4902 Harsh4902 Oct 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I totally agree here. We can use that functionality to shift our validation much closer to the actual user input.

for _, f := range strings.Split(args[0], ",") {
lower := strings.ToLower(f)
if !strings.HasPrefix(lower, "https://") && !strings.HasPrefix(lower, "http://") {
return errors.Wrapf(
errors.KindUsage,
"invalid artifact URL '%s': must start with http:// or https://",
f,
)
}
}
return nil
}

func parseImportURLArg(f string) (string, bool, string) {
mainArtifact := true
secret := ""

// Check if URL starts with https or http
if strings.HasPrefix(f, "https://") || strings.HasPrefix(f, "http://") {
parts := strings.Split(f, ":")
n := len(parts)
parts := strings.Split(f, ":")
n := len(parts)

for i := 2; i < n; i++ {
if val, parseErr := strconv.ParseBool(parts[i]); parseErr == nil {
mainArtifact = val
if i+1 < n {
secret = strings.Join(parts[i+1:], ":")
}
f = strings.Join(parts[:i], ":")
break
for i := 2; i < n; i++ {
if val, parseErr := strconv.ParseBool(parts[i]); parseErr == nil {
mainArtifact = val
if i+1 < n {
secret = strings.Join(parts[i+1:], ":")
}
f = strings.Join(parts[:i], ":")
break
}
}
return f, mainArtifact, secret
Expand Down
Loading