Repository navigation
Use the fake clock in the highlighted code block copy button test - #5895
Merged
Merged
Conversation
…seconds Waits for the Python code to be highlighted, then advances the clock by 5 seconds. Needs #5893: without it, a code block with a language that is rendered before Shiki has loaded stays empty.
Eugene (OEvgeny)
marked this pull request as ready for review
October 18, 2026 17:58
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 18, 2026 17:58
Eugene (OEvgeny)
enabled auto-merge (squash)
October 18, 2026 18:04
William Wong (compulim)
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Not required, development only.
Description
As promised in #5892, the highlighted code block copy button test now uses the fake clock: it waits for the highlighted code, then advances the clock by 5 seconds instead of waiting in real time. This needed #5893's highlighter fix, merged now.
Specific Changes
__tests__/html2/markdown/codeBlockCopyButton/behavior.highlighted.html: fake clock, wait forpre.shiki,clock.tick(5_000)before asserting "Copy"I have added tests and executed them locally
I have updated
CHANGELOG.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed