Skip to content

Test that an activity updated into or out of a part grouping renders once - #5970

Open
Eugene (OEvgeny) wants to merge 1 commit into
mainfrom
OEvgeny/fix-leave-group-test
Open

Eugene (OEvgeny) wants to merge 1 commit into
mainfrom
OEvgeny/fix-leave-group-test

Conversation

@OEvgeny

Copy link
Copy Markdown
Collaborator

Adds end-to-end coverage for #5967: an activity updated out of (or into) a part grouping renders once.

Changelog Entry

Not required, test-only change.

Description

#5967 fixed the store so an activity updated into, out of, or between part groupings renders once; its tests are unit tests of upsert(). These html2 tests cover the rendered transcript, including the avatar and checkmark rows that re-render on a group change (#5966's useLogicalGroupKey()), and fail before #5967 with the development "graph has 3 activities, Redux has 4 activities" error.

Specific Changes

  • part-grouping/leaveGroup.html: snapshots 1–2, step 2 leaves the group: once, own avatar, no checkmark
  • part-grouping/joinGroup.html: snapshots 1–2, step 2 joins the group: once, between steps 1 and 3
  • I have added tests and executed them locally
  • I have added .changelog/<PR#>-<slug>.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny Eugene (OEvgeny) added the no-changelog No .changelog/ fragment needed (development environment or test-only change) label Oct 23, 2026
@OEvgeny
Eugene (OEvgeny) marked this pull request as ready for review October 23, 2026 18:04
Copilot AI balanced review requested due to automatic review settings October 23, 2026 18:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No .changelog/ fragment needed (development environment or test-only change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants