Repository navigation
fix: URLDataTypeSerializer recognizes mixed-case HTTP(S) schemes - #3918
Open
Akhil Gupta (akhil9tiet) wants to merge 2 commits into
Open
Akhil Gupta (akhil9tiet) wants to merge 2 commits into
Akhil Gupta (akhil9tiet) wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change to recognize mixed-case HTTP(S) URL schemes.
No open issues 🎉
What changed in this PR
Fixes #3861 by recognizing mixed-case HTTP(S) schemes in URLDataTypeSerializer, preventing valid URLs from being treated as local files during hashing and seed ingestion.
Changes:
- Makes HTTP(S) scheme detection case-insensitive.
- Preserves the original URL spelling and existing handling of lowercase URLs and local paths.
| File | Description |
|---|---|
pyrit/memory/storage/serializers.py |
Uses a lowercase comparison to classify HTTP(S) URLs without modifying the stored value. |
Review effort: Balanced
) Addresses review feedback from romanlutz on microsoft#3918: cover uppercase and mixed-case http/https URL schemes, asserting data_on_disk() is false, the original spelling is preserved, and get_sha256_async() hashes the original UTF-8 bytes without accessing storage; plus an end-to-end add_seeds_to_memory_async() case with a real SeedPrompt and the isolated SQLite fixture, retaining a local-path case. Signed-off-by: Akhil Gupta <akhilgupta.swe@gmail.com>
Akhil Gupta (akhil9tiet)
force-pushed
the
fix/3861-url-scheme-case-insensitive
branch
from
November 5, 2026 08:34
b592da7 to
6470dc3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3861
Description
URLDataTypeSerializer used a case-sensitive startswith check ("http://", "https://") to decide whether a value is a URL or a local path, so mixed-case schemes like HTTPS://... or HtTp://... were misclassified as local files. Hashing and public seed ingestion then raised FileNotFoundError.
The scheme check is now case-insensitive (prompt_text.lower().startswith(("http://", "https://"))) while the original URL spelling is preserved in self.value.
Tests and Documentation
One-line fix; no behavior change for already-lowercase schemes. Verified the commit diff is exactly one changed line.