Repository navigation
FIX Preserve required parameters after a wire round trip - #3974
Open
Aman (its-amann) wants to merge 1 commit into
Open
Aman (its-amann) wants to merge 1 commit into
Aman (its-amann) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3854. The catalog serializes both a required default and an optional default of
Noneas JSONnull. It uses therequiredflag to distinguish them.When reading the catalog, restore
REQUIRED_VALUEfor a null or omitted default ifrequiredis true. Optional parameters still come back withNone.Roman Lutz (@romanlutz) would appreciate a review when you get a chance.
Tests and Documentation
Added a JSON round-trip test for required and optional integer parameters. The test also checks that the restored parameter still coerces string input to an integer. The parameter, registry resolution, and scenario parameter suites passed (428 tests).