Repository navigation
FIX Follow pagination when listing targets - #3975
Open
Aman (its-amann) wants to merge 1 commit into
Open
Aman (its-amann) wants to merge 1 commit into
Aman (its-amann) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3704. The API client now follows the server's cursor when listing targets, scenarios, and initializers. Calls without a limit return the full catalog. An explicit
limitstill caps the total number of results.If the server reports another page without supplying a usable new cursor, the client raises an error instead of returning an incomplete list.
Roman Lutz (@romanlutz) would appreciate a review when you get a chance.
Tests and Documentation
Added tests for all three paginated endpoints, the total limit, and missing or repeated cursors. The CLI and related backend service suites passed (949 tests, 1 skipped).
Created 205 text targets on a local backend and checked both the SDK and
pyrit_scan list-targets. Both previously stopped at 200 and now return all 205. Updated the SDK docstrings to explain the limit.