Repository navigation
[MAINT] Simplify attack history - #3997
Merged
Behnam (behnam-o) merged 3 commits intoNov 6, 2026
Merged
Behnam (behnam-o) merged 3 commits into
Behnam (behnam-o) merged 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing the Open button leaves attack opening on a table row without link or button semantics, making the action undiscoverable to screen-reader users navigating by links or buttons.
1 open issue
What changed in this PR
Simplifies PyRIT’s attack history around objectives and inspectable target identities, while retaining row-based navigation.
Changes:
- Replaces secondary columns with objectives, expandable targets, and last-update timestamps.
- Removes attack-type and converter filters, including their URL handling and option requests.
- Exposes saved target identifiers and updates unit and browser coverage.
| File | Description |
|---|---|
| tests/unit/backend/test_mappers.py | Tests saved target identity serialization. |
| pyrit/backend/models/attacks.py | Exposes persisted target identifiers. |
| frontend/src/types/index.ts | Adds the target identifier field. |
| frontend/src/components/Registry/RegistryIdentityRow.tsx | Supports clickable rows and optional identity expansion. |
| frontend/src/components/History/HistoryFiltersBar.tsx | Removes attack-type and converter controls. |
| frontend/src/components/History/HistoryFiltersBar.test.tsx | Updates filter-control coverage. |
| frontend/src/components/History/historyFilters.ts | Removes obsolete filter state and URL parameters. |
| frontend/src/components/History/historyFilters.test.ts | Tests ignoring removed URL filters. |
| frontend/src/components/History/AttackTable.tsx | Displays objectives and expandable target identities. |
| frontend/src/components/History/AttackTable.test.tsx | Tests navigation, expansion, and target resolution. |
| frontend/src/components/History/AttackHistory.tsx | Simplifies requests and passes registry data to rows. |
| frontend/src/components/History/AttackHistory.test.tsx | Updates history integration coverage. |
| frontend/src/components/History/AttackHistory.styles.ts | Adjusts layout for objectives and fewer columns. |
| frontend/src/App.tsx | Supplies registry targets and errors to history. |
| frontend/src/App.test.tsx | Updates URL filter hydration assertions. |
| frontend/e2e/touch-targets.spec.ts | Checks the target-expansion touch control. |
| frontend/e2e/history.spec.ts | Covers saved identities and simplified history behavior. |
| frontend/e2e/converters.spec.ts | Updates expectations for removed converter displays. |
Review effort: Balanced
Richard Lundeen (richlundeen)
left a comment
Richard Lundeen (richlundeen)
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the current head. Two additional issues are noted inline.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Richard Lundeen (richlundeen)
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Show objectives and expandable target names in attack history. Remove unused columns and filters, and open attacks by clicking their rows.
Before
After
Tests and Documentation
History and target-identity coverage updated; documentation unchanged. JupyText is not applicable.