Repository navigation
End JSONC line comments at carriage returns - #1006
Closed
user (astunm) wants to merge 1 commit into
Closed
user (astunm) wants to merge 1 commit into
user (astunm) wants to merge 1 commit into
Conversation
Leonard Hecker (lhecker)
requested changes
Nov 11, 2026
Leonard Hecker (lhecker)
left a comment
Leonard Hecker (lhecker)
left a comment
Member
There was a problem hiding this comment.
Actually, this project fundamentally does not support CR line endings anywhere.
Is there a specific issue you're trying to solve with this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop
//comments at CR as well as LF so settings files with CR line endings keep the following settings. Adds LF, CRLF, and CR regression coverage.The new regression fails before the fix. Workspace tests (97 unit tests and 3 doctests), the ICU runtime check, formatting, and strict Clippy pass locally.