Skip to content

Infrastructure: Convert Storybook lifecycle takeover into desktop-test resource contributions #4449

Closed

Description

@JasonVMo

Current status - 2026-11-16

Ready; unblocked by #4490 (F6). Merged prerequisites: F1 composition (#4455), F7 boundary guards (#4454), F2 settled lifecycle and F3 lifelines/readiness (#4463), F6 manifest provenance and credential isolation (#4490), the generic attach-only handoff from F11 (#4491), and neutral application ownership (#4492 macOS, #4494 Windows). #4442, #4444, #4445, #4446, #4447 and #4448 are closed.

Storybook still replaces the neutral CLI lifecycle through its transitional integration (integration.run, supportsAgent, adapter-written readiness), and its outer CLI claim still carries unregistered target/instance placeholders (#4492). The shared driver-service factory, typed resources, and passing smoke do not mean this takeover has been removed. Migrate Metro, channel, context and workload runners to the same real neutral resource owner. Preserve CLI compatibility and Windows port 8081, and never adopt unknown occupants or start a redundant driver. Preserve the #4490 contracts while moving code: strict v3 manifests, owner-private bridge and attachment credentials, helper provenance re-verified by the channel child, and the protected Windows lease.

Existing attach-only behavior is sufficient; native supervisor launch and transparent bridge reconnect are not global prerequisites. F4 #4437 and F5 #4443 are closed (#4463), and their macOS evidence moved to #4441. They gated exclusive controlled-context claims, not the base contribution migration.

Follow-up phases moved here from closed F11 #4448 and F10-M #4446 are listed under Scope: Storybook runner handoff, the retained supervisor-launched application option, and relocation of Storybook's macOS attach-lease duties.

Goal

storybook-desktop replaces the whole desktop-test CLI lifecycle through integration.run; #4434 marks that takeover, supportsAgent, and adapter-written readiness as transitional. Make Storybook contribute Metro, channel, context, and workload runners to the shared host instead, so storybook driver and neutral serve use one resource-ownership implementation.

Part of #4435 (plan item F9).

Scope

Dependencies

Acceptance

  • Generic and Storybook fixtures exercise the same real seam.
  • There is one workload and resource owner and one readiness and result presentation.
  • No unnecessary second driver is started.
  • The fixed Windows Metro-port policy is preserved (8081 for the Windows Debug host).
  • Unknown port occupants are never adopted.
  • Existing CLI commands remain compatible.
  • Storybook runner handoff meets the Scope criteria on each endpoint, separately qualified.
  • Generic attach-identity duties are relocated to desktop-test/application-ownership without changing Windows/Win32 attachment.

Validation

  • Iterate with focused yarn test <name> in each changed package, then run its yarn format, yarn lint, yarn build, and yarn test. Finish with yarn clean-lage-cache then yarn lage buildci; run yarn lage test-links --verbose --grouped after markdown changes.
  • Add a patch changeset for each changed published package. Update the affected topic section and its status-overview line in the owning references/current-status.md, and affected README/AGENTS guidance, in the same change.
  • Native, provider, or process-topology changes need matching-OS native contracts and the affected consumer lane. JavaScript tests and bundles do not qualify native behavior; hosted capability skips are not passes. Report each check as passed, failed, skipped, not run, or unsupported.

Evidence

  • Current state: "Storybook resource contributions" and "MCP/WDIO handoff" in packages/agentic/desktop-test/references/current-status.md; transitional annotations in packages/agentic/desktop-test/src/integration.ts. Per-run evidence lives in pull request descriptions and issues; each package's references/current-status.md keeps a status overview, stable topic sections, and only the latest result per native endpoint with a link.
  • Add scoped attach-only runner grants and drain-confirmed desktop handoff #4491 qualified the generic attach-only handoff only (macOS 5/5 and Windows 5/5, zero skips); it did not cover Storybook or retained launches.
  • Retired plan: driver-next.md at 0569e1b86, sections 6 and 8 (F9).

Activity

  1. JasonVMo commented on Nov 16, 2026

    @JasonVMo
    ContributorAuthor

    Status update: Status: Blocked removed. The blocker, F6 (#4445), landed in #4490, and the generic attach-only handoff landed in #4491; #4445, #4446, #4447 and #4448 are closed. The body now carries the follow-up phases moved here from those issues: relocating Storybook's macOS attach-lease duties, the Storybook runner handoff, and the retained supervisor-launched application option. Storybook's lifecycle takeover is still in place; no acceptance item is ticked.

  2. JasonVMo commented on Nov 17, 2026

    @JasonVMo
    ContributorAuthor

    Fixed by PR #4510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions