Skip to content

Add portable FURN skills and opt-in evals - #4514

Merged
Jason Morse (JasonVMo) merged 7 commits into
mainfrom
user/jasonvmo/skill-rework
Nov 19, 2026
Merged

Jason Morse (JasonVMo) merged 7 commits into
mainfrom
user/jasonvmo/skill-rework

Conversation

@JasonVMo

@JasonVMo Jason Morse (JasonVMo) commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

  • Add @fluentui-react-native/skills as the canonical package for four portable furn-* workflows and reviewed shared knowledge, with package/dependency catalog, provenance, explicit project-local installation, package-boundary checks, and generated repository discovery adapters.
  • Align the desktop-testing skill and catalog with Prepare desktop-driver, desktop-test, and desktop-mcp for release #4515: compatible MCP setup, drain before handoff, restart without replay, untrusted result handling, and first-party-only supervisor integration APIs. Keep driver-only mode an explicit choice, never a fallback.
  • Add a private, opt-in apps/agent-evals harness using controlled Copilot CLI trials, promptfoo, the session auditor, and synthetic MCP workloads. Normal build, lint, and test commands do not invoke a model; only the JavaScript PR test lane moves to Node 24.
  • Order the skills lint task after root prebuild so clean-checkout CI generates distribution metadata before its drift check.
  • Include changesets for the published skills, components, and framework-base packages.

Verification

Before After
No user-interface change; visual comparison not applicable. No user-interface change; visual comparison not applicable.
  • yarn install --immutable — passed with peer dependency warnings.
  • yarn workspace @fluentui-react-native/skills format, yarn workspace @fluentui-react-native/skills prebuild, yarn workspace @fluentui-react-native/skills build, yarn workspace @fluentui-react-native/skills lint, and yarn workspace @fluentui-react-native/skills test — passed, including 5 installer tests.
  • yarn clean-lage-cache then yarn lage buildci --concurrency=2 — passed, 184 tasks, including offline eval tests and instruction and package-content checks.
  • yarn lage test-links --verbose --grouped — passed, 93 tasks.
  • yarn change:check — passed.
  • The pre-rebase live eval (gpt-6.1-sol, medium) passed 4/4 synthetic cases and 54/54 assertions. Live model trials were not rerun after this rebase. No native, packed-consumer, baseline, or semantic-plan qualification is claimed for the eval.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Bundle size report

Tree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.

Scenario Modules-Mac (Δ) Modules-Win (Δ) Size-Mac (Δ) Size-Win (Δ)
components-button 79 (+1) 80 (+1) 72.92k (-702b) 72.85k (-702b)
components-catalog 228 (+1) 229 (+1) 229.66k (+349b) 229.59k (+349b)
design-themed-root 55 (+4) 56 (+4) 56.26k (+998b) 56.18k (+998b)
design-color-lib 6 (+0) 6 (+0) 6.27k (+0b) 6.27k (+0b)
design-theme-state-legacy-source 49 (+1) 50 (+1) 52.96k (-841b) 52.89k (-841b)
design-legacy-theme 42 (+0) 42 (+0) 39.11k (+0b) 42.91k (+0b)
design-legacy-theme-from-flex 58 (+4) 58 (+4) 60.70k (+824b) 64.51k (+822b)
design-fluent-light-theme 7 (+0) 7 (+0) 18.74k (+0b) 22.59k (+0b)
design-fluent-theme 35 (+0) 35 (+0) 27.46k (+4b) 31.25k (-1b)
design-fluent-hc-theme 32 (+0) 32 (+0) 27.34k (+0b) 31.13k (+0b)
design-flex-theme 29 (-4) 29 (-4) 14.30k (-9.07k) 14.29k (-9.07k)
design-flex-cool-theme 26 (New) 26 (New) 12.51k (New) 12.50k (New)
design-flex-warm-theme 26 (-7) 26 (-7) 12.28k (-11.15k) 12.27k (-11.15k)

The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail.


View bundle-size workflow run

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a3b9f3b1-d05d-4e35-b87b-1f8acf7d58c6
Serialize the skills lint drift check after root prebuild so clean CI has generated package metadata available.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2813ab12-0e92-46cd-9143-048542b77868
Document verified installation, drain and restart behavior, and untrusted result handling. Stop recommending first-party supervisor integration exports to application consumers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2813ab12-0e92-46cd-9143-048542b77868
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2813ab12-0e92-46cd-9143-048542b77868
@JasonVMo
Jason Morse (JasonVMo) enabled auto-merge (squash) November 19, 2026 20:55
@JasonVMo
Jason Morse (JasonVMo) merged commit 6fbd937 into main Nov 19, 2026
19 of 20 checks passed
@JasonVMo
Jason Morse (JasonVMo) deleted the user/jasonvmo/skill-rework branch November 19, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants