Repository navigation
Pilot JSON component tokens for Button and MenuButton - #4522
Merged
Jason Morse (JasonVMo) merged 8 commits intoNov 21, 2026
Merged
Conversation
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jason Morse (JasonVMo)
force-pushed
the
jasonmo-microsoft-component-token-layer
branch
from
November 20, 2026 20:57
4bb6079 to
afe7be0
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8dbd691-ed45-44fa-8ac2-b14a85f21e85
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jason Morse (JasonVMo)
marked this pull request as ready for review
November 20, 2026 23:00
acoates-ms
approved these changes
Nov 21, 2026
Jason Morse (JasonVMo)
deleted the
jasonmo-microsoft-component-token-layer
branch
November 21, 2026 00:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
menu-button.assets.tsxand render them with framework-basedirectComponentto avoid extra React component boundaries. The standard stories exercise the production trigger.Verification
yarn clean-lage-cache && yarn lage buildci, followed byyarn lage buildci --concurrency 1— passed on retry after unrelated transient desktop-test fixture failures. The redundantbutton.tokens.types.test.tswas removed; runtime token validation and component tests remain.3ebadea04: Fabric, Fabric physical input, and Paper all passed. The required PR aggregate passed.$env:STORYBOOK_SMOKE_STORY = 'components-menubutton--*',yarn storybook smoke --win32 --mode stories-and-testspassed 189 stories and 8/8 MenuButton tests on Win32 Paper;yarn storybook smoke --windows --mode stories-and-testspassed 216 stories and 8/8 MenuButton tests on Windows Fabric. These native runs were on the SVG-default commit0759f03d8.components-tab--overviewbecause the Storybook context did not settle. Manual screen-reader checks were not run.Pull request checklist
This PR has considered (when applicable):