Repository navigation
Fix retained Storybook channel startup timeouts in CI - #4524
Merged
Jason Morse (JasonVMo) merged 2 commits intoNov 20, 2026
Merged
Jason Morse (JasonVMo) merged 2 commits into
Jason Morse (JasonVMo) merged 2 commits into
Conversation
Allow cold CI bundles to use the channel's initial-render budget instead of timing out at the listener deadline. Keep authenticated readiness, bounded failure, and ownership-safe cleanup. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Derive default deadline expectations from the production constants and name shared test overrides without changing runtime timeout values. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jason Morse (JasonVMo)
enabled auto-merge (squash)
November 20, 2026 18:05
Vladimir Morozov (vmoroz)
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Diagnoses the recurring startup failure on Version Packages #4509 without changing that PR. The latest macOS Paper job and preceding run fail with
Owned service "storybook-channel" did not publish correlated readiness within 120000msbefore any stories run. The latest artifact shows the retained app launching at 04:55:23Z, cold Metro bundling through 04:57:15Z, and parent-requested shutdown at 04:57:30Z.The channel intentionally withholds readiness until the retained runtime authenticates and renders its first story, with a default 300-second render budget. The native smoke parent incorrectly uses its 120-second listener budget for this entire wait; the retained macOS hosted-driver path has the same mismatch.
Verification
Passed:
yarn workspace @fluentui-react-native/storybook-desktop test DesktopStorybookCli-- 113 tests passed.yarn workspace @fluentui-react-native/storybook-desktop format-- passed.yarn workspace @fluentui-react-native/storybook-desktop lint-- passed.yarn workspace @fluentui-react-native/storybook-desktop build-- passed.yarn workspace @fluentui-react-native/storybook-desktop test-- all 497 tests passed across 30 suites.yarn oxfmt --check-- passed.yarn markdown-link-check -c .github/markdown-link-check-config.json packages/agentic/storybook-desktop/references/readiness.md-- completed; no hyperlinks to check.yarn markdown-link-check -c .github/markdown-link-check-config.json packages/agentic/storybook-desktop/references/integration.md-- passed.yarn change:check-- passed after committing.yarn clean-lage-cachefollowed byyarn lage buildci-- initial aggregate failed in unchanged desktop-driverboundedCommand.test.tswaiting for a child-process ready line.yarn workspace @fluentui-react-native/desktop-driver test boundedCommandpassed all 8 tests unchanged. The first aggregate rerun overlapped draining fixture output and failed formatting on temporary files; after fixture cleanup, the finalyarn lage buildcipassed (86 executed, 100 freshly cached, zero failed).Regression control: temporarily restoring the old listener-only deadline makes both
waits past listener startupcases fail at premature shutdown. With the fix restored,yarn workspace @fluentui-react-native/storybook-desktop test DesktopStorybookCli -t 'waits past listener startup'passes both cases, including timeout/cleanup when no render arrives.Not run locally: native macOS Fabric/Paper, Windows Fabric, and Win32 smoke qualification; these remain CI gates. Portable tests are not native qualification.
Pull request checklist
This PR has considered (when applicable):