Repository navigation
Align agentic components with Flex 1.7 and add host platform tokens and desktop tooltips - #4526
Open
Jason Morse (JasonVMo) wants to merge 11 commits into
Open
Jason Morse (JasonVMo) wants to merge 11 commits into
Jason Morse (JasonVMo) wants to merge 11 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a06f5e29-1851-4153-802e-ea9ae887112d
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a06f5e29-1851-4153-802e-ea9ae887112d
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a06f5e29-1851-4153-802e-ea9ae887112d
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7d2bf93e-d37a-4021-95e1-ee6a3505c42e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7d2bf93e-d37a-4021-95e1-ee6a3505c42e
… tooltip guidance Keep MenuButton optical alignment in its token companion, balance control layout, and exercise the reviewed native tooltip routes without promoting the internal wrapper. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25351296-bdf0-4250-8665-ba74ed271c0b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25351296-bdf0-4250-8665-ba74ed271c0b
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25351296-bdf0-4250-8665-ba74ed271c0b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c34a0648-b3ee-4a0e-b51a-4cbb82e2d224
…n' into user/jasonvmo/apply-token-pattern
Jason Morse (JasonVMo)
marked this pull request as ready for review
November 21, 2026 23:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
when.platform.<host>selector for host-specific component visuals and typed theme patches. The host supplies the value; callers cannot substitute it through state. Unmatched hosts keep the base styling. MenuButton's macOS label adjustment is the first binding.Verification
yarn workspace @fluentui-react-native/design test componentTokens --silent— passed, including host precedence, unsupported-host fallback, cache isolation, and rejection of malformed selectors.yarn workspace @fluentui-react-native/components test src/components/menu-button/ src/components/tooltip/ --silent— passed (41 tests; 26 contracts validated).yarn change:checkandyarn lage test-links --verbose --grouped— passed.yarn clean-lage-cache— passed;yarn lage buildci --concurrency 1— passed after regenerating ignored skill metadata and releasing the native workload claim. No cache clear was repeated between attempts.apps/storybook,STORYBOOK_SMOKE_STORY='components-@(tooltip--native-text|menubutton--variants|input--icons)' yarn storybook smoke --macos --mode stories-and-tests --input physical— passed on Fabric. The same command with--paper— passed on Paper. Each rendered all 223 stories and passed all five selected cases on implementationc2ddac4df;fe42d89c0only records evidence.yarn storybook smoke --macos --mode stories-and-tests --input accessible— passed one14fcb15b(223 stories, 41 callbacks passed and two declared unsupported). The update control now exposes AXPress so the accessible test exercises a real native action rather than falling back to pointer input.FURN_RN_PLATFORM=win32MenuButton Jest run on macOS cannot supply Office's nativeRCTCalloutregistration; it is not native evidence. iOS and Android native presentation was not tested or claimed.Pull request checklist
This PR has considered (when applicable):