Skip to content

Align agentic components with Flex 1.7 and add host platform tokens and desktop tooltips - #4526

Open
Jason Morse (JasonVMo) wants to merge 11 commits into
mainfrom
user/jasonvmo/apply-token-pattern
Open

Jason Morse (JasonVMo) wants to merge 11 commits into
mainfrom
user/jasonvmo/apply-token-pattern

Conversation

@JasonVMo

@JasonVMo Jason Morse (JasonVMo) commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

  • Align the agentic component contracts and token companions with Flex 1.7. Button is action-only; ToggleButton owns selection. The branch includes the migration guidance and updated stories.
  • Reserve the final when.platform.<host> selector for host-specific component visuals and typed theme patches. The host supplies the value; callers cannot substitute it through state. Unmatched hosts keep the base styling. MenuButton's macOS label adjustment is the first binding.
  • Balance Button/MenuButton icon-edge padding, align the Dropdown trigger label, and fix clipped Input outlines and the Input Icons story. Preserve caller overrides.
  • Integrate the reviewed desktop Tooltip contract and direct prop on supported view-backed components. Clarify root versus trigger ownership and keep the compatibility wrapper internal pending endpoint admission. Related: Components: Generate Tooltip #4249.

Verification

  • yarn workspace @fluentui-react-native/design test componentTokens --silent — passed, including host precedence, unsupported-host fallback, cache isolation, and rejection of malformed selectors.
  • yarn workspace @fluentui-react-native/components test src/components/menu-button/ src/components/tooltip/ --silent — passed (41 tests; 26 contracts validated). yarn change:check and yarn lage test-links --verbose --grouped — passed.
  • yarn clean-lage-cache — passed; yarn lage buildci --concurrency 1 — passed after regenerating ignored skill metadata and releasing the native workload claim. No cache clear was repeated between attempts.
  • In apps/storybook, STORYBOOK_SMOKE_STORY='components-@(tooltip--native-text|menubutton--variants|input--icons)' yarn storybook smoke --macos --mode stories-and-tests --input physical — passed on Fabric. The same command with --paper — passed on Paper. Each rendered all 223 stories and passed all five selected cases on implementation c2ddac4df; fe42d89c0 only records evidence.
  • Both macOS hosts preserved the trigger's role/name, keyboard focus and Tab continuation, delivered one activation, and updated and removed AX help. See native evidence. These checks do not establish visible tooltip dismissal, dwell, persistence under magnification, or screen-reader speech.
  • yarn storybook smoke --macos --mode stories-and-tests --input accessible — passed on e14fcb15b (223 stories, 41 callbacks passed and two declared unsupported). The update control now exposes AXPress so the accessible test exercises a real native action rather than falling back to pointer input.
  • Windows Fabric and Office Win32 native runs are requested through this draft's CI. An extra FURN_RN_PLATFORM=win32 MenuButton Jest run on macOS cannot supply Office's native RCTCallout registration; it is not native evidence. iOS and Android native presentation was not tested or claimed.
Before After
Icon-bearing buttons looked uneven, Dropdown text sat high, and Input corners were clipped. The icon and text edges are balanced, trigger labels align with their icons, and rounded Input outlines follow the field radius.
Platform tweaks required component code; desktop tip text wasn't typed on supported controls. A host selector expresses visual exceptions, and supported controls forward a direct string tip without a second focus target.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a06f5e29-1851-4153-802e-ea9ae887112d
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a06f5e29-1851-4153-802e-ea9ae887112d
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a06f5e29-1851-4153-802e-ea9ae887112d
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7d2bf93e-d37a-4021-95e1-ee6a3505c42e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7d2bf93e-d37a-4021-95e1-ee6a3505c42e
… tooltip guidance

Keep MenuButton optical alignment in its token companion, balance control layout, and exercise the reviewed native tooltip routes without promoting the internal wrapper.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 25351296-bdf0-4250-8665-ba74ed271c0b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 25351296-bdf0-4250-8665-ba74ed271c0b
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Bundle size report

Tree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.

Scenario Modules-Mac (Δ) Modules-Win (Δ) Size-Mac (Δ) Size-Win (Δ)
components-button 81 (+3) 82 (+3) 77.87k (+4.24k) 77.79k (+4.24k)
components-catalog 280 (+53) 281 (+53) 257.16k (+27.84k) 257.08k (+27.84k)
design-themed-root 55 (+4) 56 (+4) 56.69k (+1.43k) 56.61k (+1.43k)
design-color-lib 6 (+0) 6 (+0) 6.27k (+0b) 6.27k (+0b)
design-theme-state-legacy-source 49 (+1) 50 (+1) 53.04k (-760b) 52.97k (-760b)
design-legacy-theme 42 (+0) 42 (+0) 39.11k (+0b) 42.91k (+0b)
design-legacy-theme-from-flex 58 (+4) 58 (+4) 61.05k (+1.17k) 64.86k (+1.17k)
design-fluent-light-theme 7 (+0) 7 (+0) 18.74k (+0b) 22.59k (+0b)
design-fluent-theme 35 (+0) 35 (+0) 27.46k (+4b) 31.25k (-1b)
design-fluent-hc-theme 32 (+0) 32 (+0) 27.34k (+0b) 31.13k (+0b)
design-flex-theme 29 (-4) 29 (-4) 14.30k (-9.07k) 14.29k (-9.07k)
design-flex-cool-theme 26 (New) 26 (New) 12.51k (New) 12.50k (New)
design-flex-warm-theme 26 (-7) 26 (-7) 12.28k (-11.15k) 12.27k (-11.15k)

The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail.


View bundle-size workflow run

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 25351296-bdf0-4250-8665-ba74ed271c0b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c34a0648-b3ee-4a0e-b51a-4cbb82e2d224
@JasonVMo
Jason Morse (JasonVMo) marked this pull request as ready for review November 21, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant