Repository navigation
Link package homepages to their subdirectories - #1881
Merged
Merged
Conversation
Contributor
Author
|
cc Raymond Zhao (@rzhao271) for review |
There was a problem hiding this comment.
🟡 Changes recommended
The published @vscode/tsconfig-gen package still needs its package-specific homepage.
1 open finding
What changed in this PR
Adds package-specific npm homepage links for published monorepo packages.
Changes:
- Adds GitHub subdirectory URLs to six package manifests.
- Leaves the published
tsconfig-genpackage uncovered.
| File | Description |
|---|---|
types/package.json |
Links to the types directory. |
textDocument/package.json |
Links to the textDocument directory. |
server/package.json |
Links to the server directory. |
protocol/package.json |
Links to the protocol directory. |
jsonrpc/package.json |
Links to the jsonrpc directory. |
client/package.json |
Links to the client directory. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dirk Bäumer (dbaeumer)
requested changes
Oct 14, 2026
Dirk Bäumer (dbaeumer)
left a comment
Dirk Bäumer (dbaeumer)
left a comment
Member
There was a problem hiding this comment.
Trivikram Kamat (@trivikr) can you please address the Copilot comment
Trivikram Kamat (trivikr)
force-pushed
the
link-homepage
branch
from
October 14, 2026 14:53
07b4015 to
594375c
Compare
Contributor
Author
Dirk Bäumer (@dbaeumer) Addressed. |
npm derives the homepage from repository.url when none is set, so every package linked to the monorepo root. Set homepage explicitly to each package's directory on main.
Trivikram Kamat (trivikr)
force-pushed
the
link-homepage
branch
from
October 16, 2026 16:03
594375c to
ac3ca2d
Compare
Dirk Bäumer (dbaeumer)
approved these changes
Oct 19, 2026
Giuseppe Cianci (Giuspepe)
approved these changes
Oct 19, 2026
Dirk Bäumer (dbaeumer)
enabled auto-merge (squash)
October 19, 2026 15:57
Anthony Kim (anthonykim1)
approved these changes
Oct 19, 2026
roblourens
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
homepagein each package'spackage.jsonso the npm page links to the package's own directory instead of the monorepo root.Without
homepage, npm derives it fromrepository.url, so every package currently links tohttps://github.com/Microsoft/vscode-languageserver-node#readme.The
repository.directoryis only used for the "Repository" link, not the homepage.The npm pages update on each package's next release.