Repository navigation
Make Async Array tests deterministic - #1889
Closed
Trivikram Kamat (trivikr) wants to merge 1 commit into
Closed
Trivikram Kamat (trivikr) wants to merge 1 commit into
Trivikram Kamat (trivikr) wants to merge 1 commit into
Conversation
The map, mapAsync and forEach tests asserted that the helpers yielded at least once, but yielding is time based (2ms in test mode). On fast machines the whole array was processed before the threshold, so the tests failed intermittently. Stall on the first item for longer than the yield threshold so the first time check always triggers a yield.
Member
|
Trivikram Kamat (@trivikr) thanks. I fixed this yesterday using a fake timer. |
Trivikram Kamat (trivikr)
deleted the
test-client-node-async-array-foreach
branch
October 16, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on #1888. Before that change,
build/bin/all.jsignored sub-package exit codes, so this intermittent failure never failed CI.The map, mapAsync and forEach tests asserted that the helpers yielded at least once, but yielding is time based (2ms in test mode). On fast machines the whole array was processed before the threshold, so the tests failed intermittently.
Stall on the first item for longer than the yield threshold so the first time check always triggers a yield.