Repository navigation
Add experimental WeChat text approval - #236
Merged
Merged
Conversation
Add Electron-owned one-use challenges, authenticated plugin transport, pre-agent reply interception, exact lossless prompt rendering, Settings controls, threat-model documentation, and comprehensive lifecycle/security tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fail closed when command display fields lack structured sensitivity provenance, including short opaque strings, numeric PIN-like values, and known credential formats. Document the conservative local-only fallback and expose it in Settings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a separate, default-off experimental WeChat text approval path for Windows Node + MXC execution.
1 CODE,2 CODE, and3 CODEapprove once, deny, or approve only the explicitly listed current batch once; bare1/2/3remain ordinary messages.Threat assumption
The product intentionally trusts normalized account, sender, direct-chat, upstream message ID/cursor/order, exact content, and quote/forward/group metadata supplied by the allowlisted
openclaw-weixinplugin and Gateway as authentic user input. It does not require an independent WeChat server signature. Settings and the MXC documentation disclose that compromise of the phone/session, plugin, or Gateway can authorize local command execution.Secret handling
OpenClaw 2026.10.2 does not provide reliable sensitive-value provenance for every displayed execution field. Remote prompts therefore use a conservative structured allowlist and exact lossless rendering. The command must reconstruct exactly from signed argv; only classified structural paths/switches/values are eligible. Secret-bearing, arbitrary positional text or numbers, short opaque values, inline option values, URLs, long tokens, credential-semantic names, Unicode/free-form data, and all unknown forms remain local-only. Regression coverage includes passphrases, Azure
AccountKey/SASsig, npm-style tokens, Slack-style tokens, short passphrases, PIN/OTP-like values, and unknown credential forms.Validation
tsc --noEmitand renderervue-tsc --noEmitgit diff --checkResidual risk
This is experimental and intentionally conservative: legitimate commands can remain local-only when display sensitivity cannot be proven. Security still depends on the trusted plugin/Gateway ingress metadata and the authenticated WeChat session. No live-account end-to-end test was performed, and no live Electron/Gateway/WeChat runtime was started or restarted during validation.