✨ add error response rst output - #463
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The critical raw_http initialization issue and pointer fallback issue remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This pull request adds RST-formatted V2 error responses and standardizes test resource-path constants.
Changes:
- Adds RST output and regression coverage for V2 errors.
- Renames shared test resource constants from
*_DIRto*_PATH. - Updates related documentation and changelog formatting.
Review findings: Critical (3 votes): V2 HTTP exceptions may expose an uninitialized raw_http. Nit (1 vote): omitted error pointers render as None instead of an empty fallback.
| File | Change |
|---|---|
tests/v2/test_client.py |
Updates V2 resource paths. |
tests/v2/test_client_integration.py |
Updates integration fixture paths. |
tests/v2/test_cli.py |
Updates CLI fixture paths. |
tests/v2/search/test_rag_document_search.py |
Updates search resource path. |
tests/v2/search/test_model_search.py |
Updates search resource path. |
tests/v2/product/utils.py |
Updates product sample paths. |
tests/v2/product/split/test_split_integration.py |
Updates split sample path. |
tests/v2/product/ocr/test_ocr_integration.py |
Updates OCR sample path. |
tests/v2/product/extraction/test_extraction_response.py |
Updates extraction fixture path. |
tests/v2/product/crop/test_crop_integration.py |
Updates crop sample path. |
tests/v2/product/classification/test_classification_integration.py |
Updates classification sample path. |
tests/v2/parsing/test_job_response.py |
Updates job resource path. |
tests/v2/parsing/test_failed_inference_response.py |
Updates error resource path. |
tests/v2/parsing/test_error_response.py |
Adds RST output regression coverage. |
tests/v2/input/test_local_response.py |
Updates local response fixture path. |
tests/v2/input/test_inference_parameters.py |
Updates parameter fixture path. |
tests/v2/file_operations/test_split_operation.py |
Updates split operation fixtures. |
tests/v2/file_operations/test_split_operation_integration.py |
Updates split integration paths. |
tests/v2/file_operations/test_crop_operation.py |
Updates crop operation fixtures. |
tests/v2/file_operations/test_crop_operation_integration.py |
Updates crop integration paths. |
tests/v1/workflows/test_workflow.py |
Updates workflow resource path. |
tests/v1/workflows/test_workflow_integration.py |
Updates workflow sample path. |
tests/v1/test_client.py |
Updates V1 client fixture paths. |
tests/v1/test_cli.py |
Updates V1 CLI fixture paths. |
tests/v1/product/us/bank_check/test_bank_check_v1.py |
Updates bank-check fixture path. |
tests/v1/product/us/bank_check/test_bank_check_v1_regression.py |
Updates regression fixture paths. |
tests/v1/product/receipt/test_receipt_v5.py |
Updates receipt fixture path. |
tests/v1/product/receipt/test_receipt_v5_regression.py |
Updates regression fixture paths. |
tests/v1/product/passport/test_passport_v1.py |
Updates passport fixture path. |
tests/v1/product/passport/test_passport_v1_regression.py |
Updates regression fixture paths. |
tests/v1/product/multi_receipts_detector/test_multi_receipts_detector_v1.py |
Updates detector fixture path. |
tests/v1/product/multi_receipts_detector/test_multi_receipts_detector_v1_regression.py |
Updates regression fixture paths. |
tests/v1/product/invoice/test_invoice_v4.py |
Updates invoice fixture path. |
tests/v1/product/invoice/test_invoice_v4_regression.py |
Updates regression fixture paths. |
tests/v1/product/invoice_splitter/test_invoice_splitter_v1.py |
Updates splitter fixture path. |
tests/v1/product/invoice_splitter/test_invoice_splitter_v1_regression.py |
Updates regression fixture paths. |
tests/v1/product/international_id/test_international_id_v2.py |
Updates product fixture path. |
tests/v1/product/generated/test_generated_v1.py |
Updates generated-response paths. |
tests/v1/product/fr/id_card/test_id_card_v2.py |
Updates ID-card fixture path. |
tests/v1/product/fr/id_card/test_id_card_v2_regression.py |
Updates regression fixture paths. |
tests/v1/product/fr/id_card/test_id_card_v1.py |
Updates ID-card fixture path. |
tests/v1/product/fr/id_card/test_id_card_v1_regression.py |
Updates regression fixture paths. |
tests/v1/product/fr/carte_grise/test_carte_grise_v1.py |
Updates carte-grise fixture path. |
tests/v1/product/fr/carte_grise/test_carte_grise_v1_regression.py |
Updates regression fixture paths. |
tests/v1/product/fr/bank_account_details/test_bank_account_details_v2.py |
Updates fixture path. |
tests/v1/product/fr/bank_account_details/test_bank_account_details_v2_regression.py |
Updates regression fixture paths. |
tests/v1/product/fr/bank_account_details/test_bank_account_details_v1.py |
Updates fixture path. |
tests/v1/product/fr/bank_account_details/test_bank_account_details_v1_regression.py |
Updates regression fixture paths. |
tests/v1/product/financial_document/test_financial_document_v1.py |
Updates financial-document fixture path. |
tests/v1/product/financial_document/test_financial_document_v1_regression.py |
Updates regression fixture paths. |
tests/v1/product/custom/test_custom_v1.py |
Updates custom-product paths. |
tests/v1/product/custom/test_custom_v1_v2.py |
Updates custom-product paths. |
tests/v1/product/custom/test_custom_v1_line_items.py |
Updates line-item fixture paths. |
tests/v1/product/cropper/test_cropper_v1.py |
Updates cropper fixture path. |
tests/v1/product/cropper/test_cropper_v1_regression.py |
Updates regression fixture paths. |
tests/v1/product/barcode_reader/test_barcode_reader_v1.py |
Updates barcode fixture path. |
tests/v1/product/barcode_reader/test_barcode_reader_v1_regression.py |
Updates regression fixture paths. |
tests/v1/parsing/common/test_ocr.py |
Updates OCR resource paths. |
tests/v1/mindee_http/test_error.py |
Updates HTTP error fixture paths. |
tests/v1/extras/test_full_text_ocr.py |
Updates OCR extra paths. |
tests/v1/extras/test_extras_integration.py |
Updates integration sample paths. |
tests/v1/extraction/test_pdf_extractor.py |
Updates extraction paths. |
tests/v1/extraction/test_multi_receipts_extractor.py |
Updates extraction fixture paths. |
tests/v1/extraction/test_invoice_splitter_auto_extraction.py |
Updates splitter fixture paths. |
tests/v1/extraction/test_image_extractor.py |
Updates image fixture paths. |
tests/v1/api/test_response.py |
Updates response fixture paths. |
tests/v1/api/test_feedback_response.py |
Updates feedback fixture path. |
tests/v1/api/test_async_response.py |
Updates async resource paths. |
tests/utils.py |
Renames shared resource constants. |
tests/input/test_inputs.py |
Updates input fixture paths. |
tests/input/test_fix_pdf.py |
Updates PDF fixture paths. |
tests/input/test_compression.py |
Updates compression fixture paths. |
tests/input/test_apply_page_options.py |
Updates page-option fixture paths. |
mindee/v2/parsing/error/error_response.py |
Adds common response support and RST formatting. |
mindee/v2/mindee_http/mindee_api_v2.py |
Corrects the deprecated method reference. |
CHANGELOG.md |
Adjusts changelog spacing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Invalid Protocol inheritance prevents imports, and HTTP error typing introduces compatibility issues.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
Resolved since last review (1)
ianardee
force-pushed
the
better-error-response
branch
from
September 21, 2026 17:02
6323a28 to
1844d63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes