Repository navigation
ci(publish): fix pnpm setup, fail fast on missing tag - #42
Merged
Merged
Conversation
Remove the explicit version: 10 from pnpm/action-setup; pnpm is now derived from packageManager (pnpm@10.15.0) in package.json. The duplicate specification made the action abort with Multiple versions of pnpm specified, which blocked the sdk-v1.1.1 publish run (42012986263) at Install pnpm after checkout and the version check had already passed. Also trim the tag input and verify the release tag exists on origin (git ls-remote --exit-code) in the derive step, so a wrong tag name fails in about 2 seconds with a clear message instead of three git fetch retries ending in a bare git exit-code-1 error (the Oct 28 dispatch used tag sdk-v1.1.2, which does not exist).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to the Publish workflow:
packageManager: pnpm@10.15.0was added to the rootpackage.json,pnpm/action-setupaborts with "Multiple versions of pnpm specified" because the workflow also passedversion: 10. The explicitversion:input is removed so the action derives pnpm frompackageManager. This blocked thesdk-v1.1.1publish run 42012986263 at step 5, after checkout and the version check had already passed.tag=sdk-v1.1.2, which does not exist on origin; checkout then spent ~23s in three git fetch retries before failing with a bare "git failed with exit code 1". The derive step now trims the input and checksgit ls-remote --exit-codeforrefs/tags/$TAGbefore proceeding, so a wrong tag name fails in ~2s with a clear message.Test plan
sdk-v1.1.1passes Install pnpm and completes through Stage publish