Skip to content

build: ignore the RUSTSEC-2026-0543 chrono advisory - #2164

Closed
nullPointerEnjoyer wants to merge 1 commit into
masterfrom
build/ignore-rustsec-2026-0543
Closed

nullPointerEnjoyer wants to merge 1 commit into
masterfrom
build/ignore-rustsec-2026-0543

Conversation

@nullPointerEnjoyer

Copy link
Copy Markdown
Collaborator

The RustSec advisory DB picked up RUSTSEC-2026-0543 (chrono unmaintained) on 2026-11-17, turning cargo deny red on every branch, including PR CI runs (#2095's static checks failed on it).

  • The advisory covers every published version of chrono and offers no safe upgrade, so no lockfile update can clear it.
  • chrono is a direct dependency of our own common crate (timestamp handling); migrating to the recommended alternatives (jiff or time) is a workspace-wide refactor that will land separately.
  • This is an unmaintained-class notice, not a vulnerability report.

Adds the advisory to the deny.toml ignore list with a justification comment, matching the existing treatment of RUSTSEC-2026-0441 (pin-utils) and RUSTSEC-2024-0436 (paste).

Verified locally: cargo deny check advisories → ok.

The RustSec advisory DB picked up RUSTSEC-2026-0543 (chrono
unmaintained) on 2026-11-17, turning 'cargo deny' red on every branch
and on master's runs. The advisory covers every published version and
offers no safe upgrade, so no lockfile update can clear it. chrono is a
direct dependency of our own 'common' crate (timestamp handling);
migrating to the recommended alternatives ('jiff' or 'time') is a
workspace-wide refactor that will land separately.

Ignore the advisory with a justification comment, matching the existing
treatment of RUSTSEC-2026-0441 (pin-utils) and RUSTSEC-2024-0436
(paste). This is an unmaintained-class notice, not a vulnerability
report.
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🔍 OpenCodeReview found 1 issue(s) in this PR.

  • ✅ Successfully posted inline: 0 comment(s)
  • 📋 Routed to summary by policy: 1 comment(s)

documentation · low

📄 deny.toml (L66-L67)

⚠️ GitHub could not post this as an inline comment: Routed to summary (severity low · category documentation)

The comment claims chrono is a direct dependency of only the "common" crate, but it is actually a direct workspace dependency in five crates: common, api-server/storage-test-suite, node-gui, node-gui/backend, and wallet/wallet-cli-commands. Understating the scope may mislead the future refactor/migration effort referenced here; consider updating the wording (and possibly linking a tracking issue, as the project does for other ignores).

💡 Suggested Change

Before:

# handling), and migrating to the recommended alternatives ("jiff" or
    # "time") is a workspace-wide refactor that will land separately. This is

After:

    # is a direct dependency of several workspace crates (common,
    # api-server/storage-test-suite, node-gui, wallet-cli-commands, ...), and
    # migrating to the recommended alternatives ("jiff" or
    # "time") is a workspace-wide refactor that will land separately.

@nullPointerEnjoyer
nullPointerEnjoyer deleted the build/ignore-rustsec-2026-0543 branch November 18, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant