Repository navigation
CI: pin cargo-deny/cargo-vet install versions - #2168
Conversation
|
🔍 OpenCodeReview found 4 issue(s) in this PR.
📄
|
|
|
||
| - name: Install cargo-deny | ||
| run: cargo install cargo-deny --locked | ||
| run: cargo install cargo-deny --locked --version 0.21.0 --version 0.21.0 |
There was a problem hiding this comment.
cargo-deny's install accepts only one --version flag; repeating it twice will cause a CLI argument error, breaking all three jobs. Keep a single --version 0.21.0.
Suggestion:
| run: cargo install cargo-deny --locked --version 0.21.0 --version 0.21.0 | |
| run: cargo install cargo-deny --locked --version 0.21.0 |
|
|
||
| - name: Install cargo-vet | ||
| run: cargo install cargo-vet --locked | ||
| run: cargo install cargo-vet --locked --version 0.10.2: |
There was a problem hiding this comment.
Stray trailing colon after the version: --version 0.10.2: is not a valid semver, so cargo will fail to parse it and the install step will error in all three jobs.
Suggestion:
| run: cargo install cargo-vet --locked --version 0.10.2: | |
| run: cargo install cargo-vet --locked --version 0.10.2 |
cargo-deny 0.22.0 was released today and requires rustc 1.95, breaking every static-checks run on the 1.92 toolchain (the current runs for #2093 and #2167 fail at the install step). Pin cargo-deny to 0.21.0 (the last release supporting the CI toolchain) and cargo-vet to the version currently in use, preventing this breakage class. Unpinned install-latest steps are a standing availability risk for every PR's CI.