Repository navigation
Read the thread indicator as a standard variable (#106) - #135
Merged
Merged
Conversation
The Variables step writes a standard variable URI to thread.response_variable_id. graphql_engine repoints the foreign key at modelcatalog_standard_variable, so the relationship now resolves there and carries a label instead of a name. Every place that showed the raw stored id -- the combobox trigger, the thread summary, the expansion panel and the wizard step summary -- would otherwise show the URI. They now prefer the label and fall back to the id.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Run against the dev cluster with the #106 migration applied. The whole diff is the relationship move: thread and task driving/response variables now resolve to modelcatalog_standard_variable, and the four array relationships move with them. No type is added or removed.
This was referenced Aug 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client half of #106. The schema half is
mintproject/graphql_engine#15, which repoints
thread.response_variable_idandtask.response_variable_id(and both drivingvariable columns) at
modelcatalog_standard_variable.What changes here
After the repoint the stored id is a URI such as
https://w3id.org/okn/i/mint/DRAWDOWN, and theresponse_variablerelationshipresolves to a standard variable, which has a
label, not aname.GetThreadselecteddriving_variable { id name }andresponse_variable { id name }.namedoes not exist onmodelcatalog_standard_variable, so the whole query would have failed and thethread page with it. Both now select
label.Variables step combobox trigger, the thread summary, the thread expansion
panel, and the wizard step summary. All four now prefer the label and fall
back to the id.
generated/schema.graphqlandgenerated/graphql.tsare regenerated againsta Hasura carrying the migration. The whole diff is the relationship move; no
type is added or removed, so the dev schema and the committed one agree on
everything else.
VariablesStepalready wrote the standard variable id, so the write path isunchanged — it just stops failing.
Order of deployment
This is safe to merge before the migration but must not ship to a Hasura that
still has the old constraint:
labelwould not resolve. Mergemintproject/graphql_engine#15 and apply the migration first.
Verified
npx vitest run— 103 files pass, including two new tests: the storedindicator shows by label, and falls back to the URI when no label is carried.
npm run build,npm run lint(0 errors),prettier --checkclean.thread.response_variableresolves tomodelcatalog_standard_variableandreturns
{ id: ".../TOTAL_WATER_STORAGE", label: "total_water_storage" }.Writing a URI succeeds; writing the bare
drawdownis now the one refused.