Repository navigation
Remove the install notice printed on every build - #21
Merged
Merged
Conversation
The banner told users who already had mkdocs-ng-material to install it, and 9.8.0 linked to the old documentation address.
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
mkdocs build/servewith mkdocs-ng-material printed a "Notice from MkDocs NG Material" banner. The code only runs when mkdocs-ng-material is installed, so the "Install: pip install mkdocs-ng-material" line was always shown to people who already have it. In 9.8.0 the docs link also points to the old address (mkdocs-ng.github.io/mkdocs-material/).This removes the banner from
src/templates/__init__.pyand the builtmaterial/templates/__init__.py, and adds a changelog line under 9.8.1.Checked: with mkdocs-ng 1.11.1, mkdocs-ng-material 9.8.0 and upstream mkdocs-material 9.8.0 installed side by side, 9.8.0 prints the banner; after installing this branch,
mkdocs buildprints only the usual INFO lines, andimport materialstill resolves tomkdocs_ng_material/material.