Repository navigation
Validate .npy shape in mlx/io/load.cpp - #4657
Merged
Merged
Conversation
A negative dimension or an overflowing product made the allocated byte count wrap to ~0 while size() stayed large, causing out-of-bounds access. Reject negative dims and use a checked multiply that throws on overflow.
zcbenz
force-pushed
the
fix-npy-shape-validation
branch
2 times, most recently
from
October 9, 2026 10:00
af0d855 to
17d85e9
Compare
zcbenz
approved these changes
Oct 9, 2026
zcbenz
changed the title
zcbenz
force-pushed
the
fix-npy-shape-validation
branch
from
October 9, 2026 10:04
17d85e9 to
af371f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative dimension or an overflowing product made the allocated byte count wrap to ~0 while size() stayed large, causing out-of-bounds access. Reject negative dims and use a checked multiply that throws on overflow.
Fixes #4646