Repository navigation
docs(oauthex): correct MatchesResource trailing-slash description - #1339
Merged
guglielmo-san merged 2 commits intoOct 4, 2026
Conversation
The doc comment said the relaxation was "narrowed to the empty-path case" and that all other components "must match exactly". The implementation compares strings.TrimSuffix(resource, "/") against strings.TrimSuffix(c, "/"), which folds a single trailing slash on ANY path, not just the empty-path case. So e.g. "https://h/a/" and "https://h/a" compare equal — which the old comment said must not happen. The broad trailing-slash fold is intentional (see the function's own Background paragraph), so this corrects the description to match the code; audience (aud) matching behavior is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
guglielmo-san
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MatchesResource's doc says the relaxation is "narrowed to the empty-path case" and that all other components "must match exactly". But the implementation comparesstrings.TrimSuffix(resource, "/")againststrings.TrimSuffix(c, "/"), which folds a single trailing slash on any path — so e.g.https://h/a/andhttps://h/acompare equal, which the old wording said must not happen.The broad trailing-slash fold is intentional (see the function's own Background paragraph), so this corrects the description to match the code. Audience (
aud) matching behavior is unchanged; doc-only.go build ./...,go vet ./oauthex/,go test ./oauthex/pass.🤖 Generated with Claude Code