Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows a default
git cloneusescore.autocrlf=true, somcp/testdata/files/info.txtlands on disk with CRLF.TestServerConformanceasserts the exact base64 of that file, so the test fails on every such checkout:Decoded, those are
"Contents\n"and"Contents\r\n"respectively -- the only difference is the checkout, not the content.A 6-line
.gitattributespins the fixtures (and all*.txtar) to LF, which is what the assertions assume:go test ./...passes with the change.Caveat for anyone with an existing Windows clone: the fixture is already on disk as CRLF, so it needs
git checkout -- mcp/testdata/files/info.txt(or a fresh clone) before the fix takes effect locally.