Skip to content

fix(client): accept tool results without content - #1434

Open
DaleSeo wants to merge 1 commit into
mainfrom
DaleSeo/call-tool-meta-only
Open

DaleSeo wants to merge 1 commit into
mainfrom
DaleSeo/call-tool-meta-only

Conversation

@DaleSeo

@DaleSeo DaleSeo commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Motivation and Context

After #1405, _meta alone no longer marks a payload as a CallToolResult in the untagged ServerResult union. That fixed custom results such as skills/list being swallowed, but a tool reply with no content now decodes as something else:

Reply Decodes as
{"_meta": {...}} CustomResult
{"resultType": "complete", "_meta": {...}} TaskAckResult
{} EmptyResult

How Has This Been Tested?

Add tests

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@github-actions github-actions Bot added T-test Testing related changes T-config Configuration file changes T-core Core library changes T-service Service layer changes labels Nov 5, 2026
@github-actions
github-actions Bot requested a review from jamadeo November 5, 2026 15:47
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@jamadeo is on triage rotation this week and is the reviewer for this one.

Labels come from the PR labeler. Please review the change.

Automated triage. Labels are a first pass and the assigned maintainer has the final say.

@DaleSeo
DaleSeo marked this pull request as ready for review November 5, 2026 15:50
@DaleSeo
DaleSeo requested a review from a team as a code owner November 5, 2026 15:50
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T15:52:28.166115Z cb3699a Draft marked ready
🔒 Security Review ✅ Completed 2026-11-05T15:54:46.371439Z cb3699a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@DaleSeo DaleSeo self-assigned this Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-config Configuration file changes T-core Core library changes T-service Service layer changes T-test Testing related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant