Repository navigation
fix(client): ignore late discovery replies after legacy fallback - #1436
Draft
charliermarsh wants to merge 1 commit into
Draft
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
github-actions
Bot
added
T-test
Contributor
|
@jamadeo is on triage rotation this week and is the reviewer for this one. Labels come from the PR labeler. Please review the change. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A legacy stdio server that takes 12 seconds to start can connect if it ignores
server/discover, yet fail if it repliesMethod not found. After 10 seconds, the client has already sentinitializewith ID 1. When the discovery error arrives with ID 0, the client gives up before reading the valid reply for ID 1.We now remember the ID of the last discovery attempt. After a timeout, the client skips late successes and errors for that ID while it waits for
initialize.Closes #1400.