Repository navigation
fix(skills): prevent symlink swaps during catalog loads - #1438
Open
tsarlandie-oai wants to merge 1 commit into
Open
tsarlandie-oai wants to merge 1 commit into
tsarlandie-oai wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
@jamadeo is on triage rotation this week and is the reviewer for this one. Labels come from the PR labeler. Please review the change. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1409. The base is
DaleSeo/skills-fs.Motivation
The catalog walks a skill directory and reads file contents later. If a regular file or one of its parent directories is replaced with a symlink between those steps, the read can publish a hidden or sibling file under the original skill URI. Both paths can be inside the configured catalog root.
Changes
cap-fs-extcompanion tocap-stdunder the optionalskills-fsfeature.Validation
58f424a.cargo test -p rmcp --features skills-fs,client --lib --test test_skill_catalogpassed all 298 library tests and 30 catalog integration tests on Linux. All 14test_skillsprotocol tests also passed.cargo clippy -p rmcp --no-default-features --features skills-fs --lib -- -D warnings,cargo +nightly fmt --all -- --check, and the repository spelling check passed.cargo check --target x86_64-pc-windows-gnupassed for theskills-fslibrary. The repository’s full CI workflow runs on PRs targetingmainorrelease.